Configure check for python clears any OS preset CFLAGS

Bug #1879445 reported by zdohnal on 2020-05-19
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
HPLIP
Undecided
Unassigned

Bug Description

Hi,

thank you for version 3.20.5 and for native configure check for appending python CFLAGS needed for compilation!

However, the current configure check does not take into account there can be some flags set already in CFLAGS (e.g. OS build systems add common security related compiler flags, or an user can have CFLAGS set on its own).

I created the patch fixing the issue and I enhanced python check too.

FYI python2 support in python upstream already ended at 1st January 2020, so there's no need to check for python2 (whole python2 support can be removed too).

The patch is attached.

Revision history for this message
zdohnal (zdohnal) wrote :
Revision history for this message
Daniel Pielmeier (daniel-pielmeier) wrote :

Thank you very much for the patch. I made a slight modification to not use bashisms in the tests. This way it works with alternative shells.

For reference the corresponding Gentoo Bug is https://bugs.gentoo.org/745459

Revision history for this message
zdohnal (zdohnal) wrote :

Hi Daniel,

thank you for the patch review and fixing the bashisms!

I'll apply the updated patch to Fedora too.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers