gcc -Wreturn-type errors in hplip
Bug #1836735 reported by
Martin Wilck
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HPLIP |
New
|
Undecided
|
Unassigned |
Bug Description
openSUSE compiles C code with the option "-Werror=
To post a comment you must log in.
Hi Martin,
I thank you for filing the issue! I as Fedora hplip maintainer got the similar pull request which fixes the issue https:/ /src.fedoraproj ect.org/ rpms/hplip/ pull-request/ 6# .
IMO your patch indeed fixes the issue, but it slows the code execution a little bit - influencing the performance. The execution goes through all if statements with your patch instead of returning after the first matched 'if' condition (as the old code did).
I'm attaching our Fedora patch.