[abrt] hplip: module(): hp-firmware:102:<module>:NameError: name 'INTERACTIVE_MODE4' is not defined

[zdohnal]

Hi,

when I run 'hp-firmware' and I do not have qt packages installed, program ends with exception:

hp-firmware:102:<module>:NameError: name 'INTERACTIVE_MODE4' is not defined

I couldn't find any other usages or definitions of INTERACTIVE_MODE4, so I think it is typo. Attached patch fixes it - now it correctly switches to INTERACTIVE_MODE if gui parts are missing.

[Nishitha Antony (ni301701)]

Hi Zdohnal,

In order to change from INTERACTIVE_MODE4 to INTERACTIVE_MODE apply the attached patch.
Steps to apply patch.
1. Go to HPLIP source code directory.
2. Apply patch using command "patch firmware.py < patch1.diff".
3. Install code using command "sudo make install"

Thanks,
Nishitha

[zdohnal (zdohnal)]

Hi Nishitha,

I think you misunderstood me. I reported this issue here with proposed patch (which I created it, attached here and it is same as yours, just diff was called above whole hplip-3.17.11 directory instead of yours, which is called only on firmware.py script) with intention that hplip upstream will include the fix in the project's next release.
I have patched and released fix in Fedora. Thank you for your instructions and your time!

Zdenek