scan.py - scans cannot be saved as JPEG since python-pillow-4.2.0

[zdohnal]

Hi,

python-pillow released new version (4.2.0), which forbids saving RGBA data to JPEG. This behavior breaks scanning by hp-scan. Output is:

$ hp-scan -m color -s file
Saving to file /home/zdohnal/hpscan001.jpg
error: Error saving file: cannot write mode RGBA as JPEG (I/O)

These RGBA data needs to be convert to RGB data before saving as JPEG (other formats - PNG, PNM, TIFF etc. - works fine, because they doesn't ignore A channel). The attached patch fixes it.

[meeuw (dick-mrns)]

Thanks for the patch, I think you should remove the if 'JPEG' condition, it's also required for raw scans.

[zdohnal (zdohnal)]

Ah, I overlooked raw option! Sorry, you're right of course.

[Nishitha Antony (ni301701)]

Hi,
We tried to reproduce the reported issue in lab and it is reproducible. We will discuss this with HP program management team for incorporating this fix in the next release and keep you posted on the updates.
Thanks,
Nishitha

[Hans-Peter Jansen (frispete)]

The change was taken over upstream in an improved form (or reinvented), hence this issue can be closed now...