hp-check: Add constants for the dependency indices
Bug #1688686 reported by
Francois Gouget
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HPLIP |
New
|
Undecided
|
Unassigned |
Bug Description
check.py and core_installer.py use literal constants such as 3, 5 or 7 to access the fields of the dependencies array. This results in very error-prone, obfuscated and unmaintainable code.
So I introduced constants: DEPENDENCY_
(I'll grant you that it's a bit verbose but to my defense I only followed the existing naming convention.)
See the attached patch. This patch can also be found on:
https:/
To post a comment you must log in.
More precisely it is on the fixes branch: /github. com/fgouget/ hplip/commits/ fixes
https:/