hp-check shows the distro index instead of its name

Bug #1688684 reported by Francois Gouget on 2017-05-06
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
HPLIP
Undecided
Unassigned
hplip (Ubuntu)
Undecided
Unassigned

Bug Description

self.core.distro is the Linux distribution's index, not its name. This results in messages such as:

   warning: 2-9.0 version is not supported. Using 2-8.6 versions dependencies to verify and install...

2 means debian!

As such it is not suitable for traces and information messages. self.core.distro_name should be used instead.

See the attached patch. This patch can also be found on:
https://github.com/fgouget/hplip

Mayou36 (mayou36) wrote :

Same for me in ubuntu 17.04

Changed in hplip:
status: New → Confirmed

The attachment "check: Fix core.distro vs. core.distro_name mixups." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
gf (gf-interlinks) wrote :

Hello Francois,
Thank you for submitting this bug and reporting a problem with hplip. You made this bug report some time ago and Ubuntu and hplip have been updated since then.

Could you confirm that this is no longer a problem and that we can close the ticket?
If it is still a problem, are you still interested in finding a solution to this bug?
If you are, could you let us know and, in the current version, could you run the following (only once):
apport-collect 1688684
and upload the updated logs and and any other logs that are relevant for this particular issue.

Thank you again for helping make Ubuntu and hplip better.
G
[Ubuntu Bug Squad volunteer triager]

Changed in hplip:
status: Confirmed → Incomplete
Changed in hplip (Ubuntu):
status: New → Incomplete
Francois Gouget (fgouget) wrote :

This part of the code has not changed so the bug is still present and the patch I provided is still valid.

Note: I rebased the https://github.com/fgouget/hplip/commits/fixes GitHub branch.

Changed in hplip:
status: Incomplete → New
Changed in hplip (Ubuntu):
status: Incomplete → New
Francois Gouget (fgouget) wrote :

This bug has a fix.
What does it take to get someone to look at the patch and decide whether to apply it?

What would be the right place to submit the patch?
Does HPLIP have a developer mailing list? Should one send pull-requests on GitHub? Against which repository?

I looked at https://developers.hp.com/hp-linux-imaging-and-printing but it's all corporate speak with a developer community link that points to over a dozen forums none of which mentions HPLIP.

gf (gf-interlinks) wrote :

Hi Francois,
I will email one of the bug team to see what the next steps should be.
Thanks
G

Till Kamppeter (till-kamppeter) wrote :

First, I am on Cosmic and ran "hp-check" and see that the bug still persists (Ubuntu is "12").

Second, you do not need to forward this patch upstream any more. HPLIP uspstream uses Launchpad as bug tracker as Ubuntu also does. Therefore it is enough to add an "HPLIP" task to the bug (via "Also affects project", already done for this bug) so that it gets also visible to the HPLIP developers at HP. I usually do this with all bugs reported on HPLIP in Ubuntu, as longs as the bug is not clearly one in the Debian/Ubuntu packaging.

Third, I will look into applying the patch to the current Ubuntu package of HPLIP.

Changed in hplip (Ubuntu):
status: New → In Progress
Till Kamppeter (till-kamppeter) wrote :

Patch applied in hplip 3.18.7+dfsg1-2ubuntu2 which is on the way into Cosmic.

Thank you very much for the patch.

Changed in hplip (Ubuntu):
status: In Progress → Fix Committed
gf (gf-interlinks) wrote :

Thanks for testing it on your computer and for applying the patch, Till!
:)
Glady

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hplip - 3.18.7+dfsg1-2ubuntu2

---------------
hplip (3.18.7+dfsg1-2ubuntu2) cosmic; urgency=medium

  * Let hp-check show distro names correctly (and not internal
    index numbers for them, LP: #1688684).

 -- Till Kamppeter <email address hidden> Thu, 4 Oct 2018 21:21:00 +0200

Changed in hplip (Ubuntu):
status: Fix Committed → Fix Released
gf (gf-interlinks) on 2018-10-09
Changed in hplip:
status: New → Fix Released

gf, note that the "hplip" task is HPLIP upstream (original development at HP), as HP also uses Launchpad as bug tracker. Up to now the proposed patch was only applied by me to the Ubuntu package of HPLIP (represented by the "hplip (Ubuntu)" task). There is no answer from the upstream yet, so we can assume that they did not yet apply this patch. Therefore I am reverting your change on the "hplip" task.

gf, in general, on HPLIP bugs do not modify the "hplip" task's status.

gf (gf-interlinks) wrote :

Ok, Till. Sorry. Could you change the HPLIP package back to "new" then, please?
Take care
:)
G

gf, for me this is all grayed out, can you set it back? Thanks.

gf (gf-interlinks) wrote :

Hi Till, It's greyed out for me too. I have contacted one of the bug control team via email to get him to change it back.
Sorry again
:/
G

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers