Should run hp-firmware from udev separately

Bug #1255033 reported by Tim Waugh on 2013-11-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Undecided
Unassigned

Bug Description

The hp-config_usb_printer tries to do too much. In particular, it tries to add queues (and remove them!), as well as downloading required firmware.

The firmware step should be separate (and in fact the add/remove queues functionality should IMHO be removed).

In Fedora, for example, the system already takes care of adding/enabling/disabling queues for USB printers. For this reason, hp-config_usb_printer is not shipped as it would cause conflicts and problems.

Please separate out the firmware downloading aspect so that can be included in Fedora and other systems that also use system-config-printer (such as Ubuntu).

Johannes Meixner (jsmeix) wrote :

Hello Tim,

I fully agree!

You may have a look at
https://bugs.launchpad.net/hplip/+bug/1220628/comments/16
and
https://bugs.launchpad.net/hplip/+bug/1220628/comments/18

This are my current changes for 56-hpmud.rules for openSUSE:
https://build.opensuse.org/package/view_file/Printing/hplip/change-udev-rules.diff?expand=1

To the HPLIP authors:

I would very much appreciate it if HPLIP upstream could provide
udev rules that work o.k. for all Linux distributions.

Hi Tim Waugh, Johannes Meixner,

Fixed this issue in HPLIP-3.14.3.

Current hp-conf_usb_printer script does the just following functionalities.
1. Check whether device has CD/DVD-ROM (Smart Install) enabled.
2. Checks plugin's installation status, for required printers
3. Download Firmware to required devices

--> If plugin's are not installed, hp-firmware will fail. So this hp_config_usb_printer script is not doing any extra functionality, hence marking Bug as fix released.

Thanks & Regards,
Amarnath

Changed in hplip:
status: New → Fix Released
Tim Waugh (twaugh) wrote :

Should the comment in data/rules/56-hpmud.rules be changed? It currently (3.14.6) says:

# This rule will add the printer and install plugin
ENV{hp_test}=="yes", PROGRAM="/bin/sh -c 'logger -p user.info loading HP Device $env{BUSNUM} $env{DEVNUM}'", RUN+="/bin/sh -c 'if [ -f /usr/bin/systemctl ]; then /usr/bin/systemctl --no-block start hplip-printer@$env{BUSNUM}:$env{DEVNUM}.service; else /usr/bin/nohup /usr/bin/python /usr/bin/hp-config_usb_printer $env{BUSNUM}:$env{DEVNUM} ; fi &'"

goutam (goutamkk) wrote :

Hi Tim,

Yes, the comment has to be changed. We will fix it in our next release of HPLIP.
Thank you for reporting it here.

Regards,
Goutam

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers