prnt/hpijs/header2.cpp:174: bad if test ?

Bug #1235116 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
New
Undecided
Unassigned

Bug Description

I just ran the static analyser "cppcheck" over the source code
of hplip-3.13.9

It said

[prnt/hpijs/header2.cpp:174]: (warning) Logical disjunction always evaluates to true: qual >= -3 || qual <= 3.

Source code is

    ASSERT (qual >= qualityAuto || qual <= qualityFastNormal);

Suggest swap || for &&

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.