Port Details VNIC type value is not translatable

Bug #1462484 reported by Doug Fish
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Itxaka Serrano
Kilo
Fix Released
Undecided
Unassigned

Bug Description

On port deatails, the Binding/VNIC type value is not translatable. To recreate the problem:
- create a pseudo translation:

./run_tests.sh --makemessages
./run_tests.sh --pseudo de
./run_tests.sh --compilemessages

start the dev server, login and change to German/Deutsch (de)

Navigate to
Project->Network->Networks->[Detail]->[Port Detail]

notice at the bottom of the panel the VNIC type is not translated.

The 3 VNIC types should be translated when displayed in Horizon
https://github.com/openstack/neutron/blob/master/neutron/extensions/portbindings.py#L73
but neutron will expect these to be provided in English on API calls.

Note that the mapping is already correct on Edit Port - the translations just need to be applied on the details panel.

Kahou Lei (kahou82)
Changed in horizon:
assignee: nobody → Kahou Lei (kahou82)
tags: added: i18n
Changed in horizon:
assignee: Kahou Lei (kahou82) → nobody
Changed in horizon:
status: New → Confirmed
importance: Undecided → High
Itxaka Serrano (itxaka)
Changed in horizon:
assignee: nobody → Itxaka Serrano (itxakaserrano)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/257271

Revision history for this message
David Lyle (david-lyle) wrote :

translation issue is not a high

Changed in horizon:
importance: High → Medium
milestone: none → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/257271
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ae0a7039b34921526bee0895981d0734e990e743
Submitter: Jenkins
Branch: master

commit ae0a7039b34921526bee0895981d0734e990e743
Author: Itxaka <email address hidden>
Date: Mon Dec 14 11:43:34 2015 +0100

    Make Port Details VNIC type translatable

    Port Details VNIC type value was not translatable.

    Change-Id: I64e16adfa8ebf08fcc81a5648f8b0a0f4404c344
    Closes-Bug: #1462484

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/277771

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/277772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/liberty)

Reviewed: https://review.openstack.org/277771
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=efa38e2c5a555f521befd412ab2943dc00254bdb
Submitter: Jenkins
Branch: stable/liberty

commit efa38e2c5a555f521befd412ab2943dc00254bdb
Author: Itxaka <email address hidden>
Date: Mon Dec 14 11:43:34 2015 +0100

    Make Port Details VNIC type translatable

    Port Details VNIC type value was not translatable.

    Change-Id: I64e16adfa8ebf08fcc81a5648f8b0a0f4404c344
    Closes-Bug: #1462484
    (cherry picked from commit ae0a7039b34921526bee0895981d0734e990e743)

tags: added: in-stable-liberty
tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/kilo)

Reviewed: https://review.openstack.org/277772
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0f652fd6a7c4b90d448210bb16c131515a57b6f5
Submitter: Jenkins
Branch: stable/kilo

commit 0f652fd6a7c4b90d448210bb16c131515a57b6f5
Author: Itxaka <email address hidden>
Date: Mon Dec 14 11:43:34 2015 +0100

    Make Port Details VNIC type translatable

    Port Details VNIC type value was not translatable.

    Change-Id: I64e16adfa8ebf08fcc81a5648f8b0a0f4404c344
    Closes-Bug: #1462484
    (cherry picked from commit ae0a7039b34921526bee0895981d0734e990e743)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 2015.1.4

This issue was fixed in the openstack/horizon 2015.1.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/horizon 2015.1.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 8.0.2

This issue was fixed in the openstack/horizon 8.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.