Event listeners are not being attached to some modal windows

[Victor Feitosa]

In some modal windows, form event listeners are not being attached correctly. For example the date picker that should be triggered on a focus event in the text box in [dashboard/admin/metering -> Modify Usage Report Parameters -> Other] is not. This might be a problem with the modal loading or a django issue.
This issue is not present if the form is not in a modal window (like it was in juno release), the event listeners are attached regularly and work as expected if the form is in a page of its own.

See attached files for reference.

Steps to reproduce:
1) Open the dashboard and go to admin/metering
2) Press the 'Modify Usage Report Parameters' button.
3) When the modal window appear select 'Other' from the spinner.
4) Click the 'from' or 'to' text inputs, a datepicker should pop out from there but it does not.
5) If you repeat these steps in juno, the datepicker will appear since the admin/metering/create url is in a page of its own.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Seems like the modals have introduced an obvious regression here, and I can still reproduce the broken behaviour reliably

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/168985

[Thierry Carrez (ttx)]

Might be included in a RC2 if this is fixed in master soon

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168985
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0d010f601cecacac01c26be572ae0d6444df9669
Submitter: Jenkins
Branch: master

commit 0d010f601cecacac01c26be572ae0d6444df9669
Author: Sam Betts <email address hidden>
Date: Mon Mar 30 16:49:24 2015 +0100

    Fix date pickers in metering modal

    The metering forms were using the date picker functionality from the
    d3 line chart library, this used to work when it was loaded as a whole
    page as the d3 libary would run intending to setup any d3 graphs however
    now it is being loaded as a modal the elements that would be affected by
    the d3 code do not exist at page load time.

    In order to get the date picker events to be added to the elements on
    the form when the modal loads, the JS in the forms template has been
    extended in this patch to support adding those events.

    This patch also changes the data attributes on the form elements so that
    they do not conflict with any d3 line chart elements.

    Alongside the javascript this patch fixes bug to do with parsing the
    dates in metering utils and adds UTs to prevent regression.

    Change-Id: I4e239daa03b2f54e434254bac48ba0cceb037b5d
    Closes-Bug: 1427756

[Matthias Runge (mrunge)]

still valid on master

[Matthias Runge (mrunge)]

ok, this is fixed on master, but not fixed in kilo

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195922

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/195922
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ec27165a8db420ea1620b87353cb565fd7e5a03d
Submitter: Jenkins
Branch: stable/kilo

commit ec27165a8db420ea1620b87353cb565fd7e5a03d
Author: Sam Betts <email address hidden>
Date: Mon Mar 30 16:49:24 2015 +0100

    Fix date pickers in metering modal

    The metering forms were using the date picker functionality from the
    d3 line chart library, this used to work when it was loaded as a whole
    page as the d3 libary would run intending to setup any d3 graphs however
    now it is being loaded as a modal the elements that would be affected by
    the d3 code do not exist at page load time.

    In order to get the date picker events to be added to the elements on
    the form when the modal loads, the JS in the forms template has been
    extended in this patch to support adding those events.

    This patch also changes the data attributes on the form elements so that
    they do not conflict with any d3 line chart elements.

    Alongside the javascript this patch fixes bug to do with parsing the
    dates in metering utils and adds UTs to prevent regression.

    Change-Id: I4e239daa03b2f54e434254bac48ba0cceb037b5d
    Closes-Bug: 1427756
    (cherry picked from commit 0d010f601cecacac01c26be572ae0d6444df9669)