Tests fail due to keystoneclient 0.10 release

[Jamie Lennox]

Tests and the gate fail with errors that look like:

Traceback (most recent call last):
  File "/home/jamie/.virtualenvs/horizon/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/jamie/work/horizon/openstack_dashboard/test/test_data/utils.py", line 48, in load_test_data
    return TestData(*loaders)
  File "/home/jamie/work/horizon/openstack_dashboard/test/test_data/utils.py", line 74, in __init__
    data_func(self)
  File "/home/jamie/work/horizon/openstack_dashboard/test/test_data/ceilometer_data.py", line 56, in data
    TEST.ceilometer_users.add(users.User(users.UserManager(None),
TypeError: __init__() takes exactly 3 arguments (2 given)

This is because the horizon test code constructs keystoneclient Managers. These aren't used by horizon so can just be replaced with None for test data.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108865
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=821619fff324ba1bc3f697f585a0c350573f24a2
Submitter: Jenkins
Branch: master

commit 821619fff324ba1bc3f697f585a0c350573f24a2
Author: Jamie Lennox <email address hidden>
Date: Wed Jul 23 08:55:55 2014 +1000

    Replace UserManager with None in tests

    Don't access keystoneclient's UserManager in tests. This should be
    considered private data of keystoneclient and is not actually used by
    horizon tests.

    Change-Id: I261e79b31dfc7388adb3dc63a3a5e54042f05e54
    Closes-Bug: #1347236

[Justin Pomeroy (jpomero)]

Should the fix be back ported to stable/icehouse? I'm seeing the same problem there.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/109286

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109286
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eb3a40a7b0e87ed9325a9d5edccdaedc2a56292e
Submitter: Jenkins
Branch: stable/icehouse

commit eb3a40a7b0e87ed9325a9d5edccdaedc2a56292e
Author: Jamie Lennox <email address hidden>
Date: Wed Jul 23 08:55:55 2014 +1000

    Replace UserManager with None in tests

    Don't access keystoneclient's UserManager in tests. This should be
    considered private data of keystoneclient and is not actually used by
    horizon tests.

    Change-Id: I261e79b31dfc7388adb3dc63a3a5e54042f05e54
    Closes-Bug: #1347236
    (cherry picked from commit 821619fff324ba1bc3f697f585a0c350573f24a2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/109525

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109525
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=df782fc2b51f5e9d2e38e3e33a4ebdc0705a50b4
Submitter: Jenkins
Branch: stable/havana

commit df782fc2b51f5e9d2e38e3e33a4ebdc0705a50b4
Author: Jamie Lennox <email address hidden>
Date: Wed Jul 23 08:55:55 2014 +1000

    Replace UserManager with None in tests

    Don't access keystoneclient's UserManager in tests. This should be
    considered private data of keystoneclient and is not actually used by
    horizon tests.

    Conflicts:
     openstack_dashboard/test/test_data/keystone_data.py

    Change-Id: I261e79b31dfc7388adb3dc63a3a5e54042f05e54
    Closes-Bug: #1347236
    (cherry picked from commit 821619fff324ba1bc3f697f585a0c350573f24a2)