Editing a User Gives a Misleading Success Message

Bug #993572 reported by John Postlethwait
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
John Postlethwait

Bug Description

Go to "users"
hit "edit"
hit "Update user" without changing anything.

I get a message which says: "Success: Updated name, email, primary project for X" even though I didn't actually update any those fields.

Changed in horizon:
status: New → In Progress
assignee: nobody → John Postlethwait (john-postlethwait)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7054

Devin Carlen (devcamcar)
Changed in horizon:
milestone: none → folsom-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/7054
Committed: http://github.com/openstack/horizon/commit/65824cb8c897ee87488a95a036ebd2dcbf1da85e
Submitter: Jenkins
Branch: master

commit 65824cb8c897ee87488a95a036ebd2dcbf1da85e
Author: John Postlethwait <email address hidden>
Date: Wed May 2 18:57:00 2012 -0700

    Fixes to the user form, UI behaviors, and tests.

    The message you got upon successful user update
    was misleading as it told you all of the fields
    were updated, even if no changes were made to
    those fields.

    Also there was an issue where in this user edit
    form, where if can_edit_user was False in the
    local_settings file, you could not change the
    default project for a user.

    Changed the stubbing behavior for tests as well
    to allow the use of a decorator to stub your tests
    using Mox instead of having to clutter up the
    actual test with repetitive Mox stubs.

    Fixes Bug #993572

    Change-Id: Iaebd6525bb4509a2ec6b350df432f4f60dd35114

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.