OpenStack Dashboard (Horizon)

Editing an image makes it public

Reported by Sam Morrison on 2012-04-26
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Gabriel Hurley
Essex
High
Tres Henry

Bug Description

When editing an image in the dashboard, eg. to rename the image after saving the image will become public.

Devin Carlen (devcamcar) on 2012-04-30
Changed in horizon:
status: New → Confirmed
importance: Undecided → High
milestone: none → folsom-1
tags: added: essex-backport-potential
Tres Henry (tres) wrote :

Sam, I'm unable to repro. Here's the two flows (with steps) I took (let me know if there are other steps to repro):

-- uploaded image flow --
1) Upload oneiric UEC image to glance in the normal way
2) Horizon -> Admin -> Images
3) Edit oneiric AMI and change name

Expected:
AMI has name changed but isn't public

Actual:
AMI name is changed and image is still private

-- snapshot flow --
1) Horizon -> Project -> Images & Snapshots
2) Launch instance from default cirros (devstack) image
3) Horizon -> Project -> Instances & Volumes
4) Snapshot instance
5) Horizon -> Admin -> Images
6) Edit snapshot image and change name

Expected:
AMI has name changed but isn't public

Actual:
AMI name is changed and image is still private

I also tested making image public and then back to private and it worked as expected. This was all tested with the latest devstack and Horizon.

Changed in horizon:
assignee: nobody → Tres Henry (tres)
status: Confirmed → Incomplete
Devin Carlen (devcamcar) on 2012-05-01
Changed in horizon:
importance: High → Undecided
Sam Morrison (sorrison) wrote :

Yes, can confirm this is fixed in master, would be good to backport this to Essex.

Gabriel Hurley (gabriel-hurley) wrote :

The fix happened incidentally when I landed my patch for using python-glanceclient instead of glance.client. So a straight backport isn't an option. A whole new patch will need to be written for Essex, with new regression tests specifically for it.

The offending line is here in Essex:

https://github.com/openstack/horizon/blob/stable/essex/horizon/dashboards/nova/images_and_snapshots/images/forms.py#L74

The form needs to have a formfield added for "is_public" as is done here in master:

https://github.com/openstack/horizon/blob/master/horizon/dashboards/nova/images_and_snapshots/images/forms.py#L69

Then the handle method uses the data here:

https://github.com/openstack/horizon/blob/master/horizon/dashboards/nova/images_and_snapshots/images/forms.py#L77

The tests will have to be redone from scratch.

Gabriel Hurley (gabriel-hurley) wrote :

This bug was fixed in https://github.com/openstack/horizon/commit/0b94c431ab8e510b5fd4e7d1e8719c7d2055fa0f for master, but still exists in stable/essex. See my comments for that series.

Changed in horizon:
assignee: Tres Henry (tres) → Gabriel Hurley (gabriel-hurley)
importance: Undecided → High
status: Incomplete → Fix Committed
Sam Morrison (sorrison) wrote :

Would an easy fix to essex be to just remove the 'is_public': True from:

https://github.com/openstack/horizon/blob/stable/essex/horizon/dashboards/nova/images_and_snapshots/images/forms.py#L74

There is no way to edit an images public status anyway so just maintaining it's current value would be better than setting it to public

Reviewed: https://review.openstack.org/7204
Committed: http://github.com/openstack/horizon/commit/7b959c2066821e829c07563bc9f84de72544017d
Submitter: Jenkins
Branch: stable/essex

commit 7b959c2066821e829c07563bc9f84de72544017d
Author: Tres Henry <email address hidden>
Date: Fri May 4 10:52:07 2012 -0700

    This is a backport which fixes the issue with images being marked public
    when edited. This is fixed in Folsom by: https://github.com/openstack/horizon/commit/0b94c431ab8e510b5fd4e7d1e8719c7d2055fa0f

    Fixes bug 988633

    Change-Id: Ia22501c2a3daac7e84c10039dd5857612e5156f4

tags: added: in-stable-essex
Thierry Carrez (ttx) on 2012-05-23
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-09-27
Changed in horizon:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers