Text shown when Keystone is unavailable and trying to list Users in SysPanel is cryptic

Bug #971250 reported by Devin Carlen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Gabriel Hurley

Bug Description

The error is handled but too much information is displayed to the end user:

"Error: Unable to get user info: Authorization Failed: Unable to communicate with identity service: Unable to find the server at [hostname]. (HTTP 400)"

"Unable to display list of users" or something to that effect would be more appropriate.

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

yep, the code here should use exceptions.handle and not insert the exception message: https://github.com/openstack/horizon/blob/master/horizon/dashboards/syspanel/users/views.py#L47

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → Medium
milestone: none → essex-rc2
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6069

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/6069
Committed: http://github.com/openstack/horizon/commit/289fc72168767c1bc0d1d4727268f17d2343a66a
Submitter: Jenkins
Branch: master

commit 289fc72168767c1bc0d1d4727268f17d2343a66a
Author: Gabriel Hurley <email address hidden>
Date: Mon Apr 2 00:15:36 2012 -0700

    Improved keystone error handling in syspanel.

      * Added "AuthorizationFailure" to the recoverable errors list
        since keystoneclient raises it anytime it can't talk to
        keystone. Fixes bug 971249.

      * Used proper exception handling for the users index view.
        Fixed some tests that had been failiing but masked previously.
        Fixes bug 971250.

    Change-Id: Iec8c1fc7bf8585a529fa15af55f807abc0f84d42

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: essex-rc2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.