UI: The login and settings screens should not use the modal styles since they are in-page content.
Bug #963482 reported by
John Postlethwait
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
High
|
Gabriel Hurley |
Bug Description
The login screen and the settings pages use the modal CSS and HTML for their content. We are starting to see issues with this where one needs to special-case CSS and JS in order for it to not affect the behavior of THOSE forms, but still works on the actual modal-dialogs that pop up and have forms.
Semantically this is also probably improper as these pages are NOT modal dialogs. They should have their own styles so they can be easily styled separately from the modal dialogs without needing to special case CSS and JS.
Changed in horizon: | |
milestone: | none → essex-rc2 |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | essex-rc2 → 2012.1 |
To post a comment you must log in.
Re: the settings pages... it's not specific to those, it's every template that inherits from modal_form.html when viewed as a static page rather than loaded dynamically as a modal. The culprit is in this line:
https:/ /github. com/openstack/ horizon/ blob/master/ horizon/ templates/ horizon/ common/ _modal_ form.html# L1
Essentially, the modal class should only be applied when the form is loaded via ajax, and the static_page class should contain a complete set of styles for appropriately displaying that content without the modal class.