UI: The login and settings screens should not use the modal styles since they are in-page content.

Bug #963482 reported by John Postlethwait on 2012-03-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Gabriel Hurley

Bug Description

The login screen and the settings pages use the modal CSS and HTML for their content. We are starting to see issues with this where one needs to special-case CSS and JS in order for it to not affect the behavior of THOSE forms, but still works on the actual modal-dialogs that pop up and have forms.

Semantically this is also probably improper as these pages are NOT modal dialogs. They should have their own styles so they can be easily styled separately from the modal dialogs without needing to special case CSS and JS.

Devin Carlen (devcamcar) on 2012-03-23
Changed in horizon:
milestone: none → essex-rc2
status: New → Confirmed
importance: Undecided → High
Gabriel Hurley (gabriel-hurley) wrote :

Re: the settings pages... it's not specific to those, it's every template that inherits from modal_form.html when viewed as a static page rather than loaded dynamically as a modal. The culprit is in this line:

https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal_form.html#L1

Essentially, the modal class should only be applied when the form is loaded via ajax, and the static_page class should contain a complete set of styles for appropriately displaying that content without the modal class.

Fix proposed to branch: master
Review: https://review.openstack.org/5791

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/5791
Committed: http://github.com/openstack/horizon/commit/9203e69f00f2ff8886bc5348632c7f15d52f6eae
Submitter: Jenkins
Branch: master

commit 9203e69f00f2ff8886bc5348632c7f15d52f6eae
Author: Gabriel Hurley <email address hidden>
Date: Sun Mar 25 14:08:27 2012 -0700

    ".modal" style only applied to modals now.

    The ".static_page" style now handles all static styling and
    looks more "static" than it did before.

    Removed a couple dead and/or extraneous templates.

    Updated translation files.

    Fixed bug 963482.

    Change-Id: I8b6af12f0752e844192db3fc6caa1fc389b0cddc

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-04-03
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers