ajax with modal form will embed new page if redirect 302 happens

Bug #961863 reported by Andy Chong on 2012-03-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Andy Chong

Bug Description

ajax could not process the 302 redirection properly
it will instead append the new redirected page content onto current page

steps to reproduce:
create a new volume -> attach it to an instance -> detach it from an instance

Fix proposed to branch: master
Review: https://review.openstack.org/5665

Changed in horizon:
assignee: nobody → Andy Chong (andycjw)
status: New → In Progress
Devin Carlen (devcamcar) on 2012-03-22
Changed in horizon:
importance: Undecided → High
tags: added: essex-rc-potential

Reviewed: https://review.openstack.org/5665
Committed: http://github.com/openstack/horizon/commit/05b208f1046c96b69af44b1aff6a8c57f8a1b44d
Submitter: Jenkins
Branch: master

commit 05b208f1046c96b69af44b1aff6a8c57f8a1b44d
Author: Andy Chong <email address hidden>
Date: Thu Mar 22 13:34:40 2012 +0800

    Fix AJAX form posting that work incorrectly if get() in base views
    is overridden by subclass, e.g. EditRulesView and EditAttachmentsView
    if they don't add X-Horizon-Location custom headers if redirect is
    used. This mucking is probably the cleanest way to fix this in
    the meantime.

     * fix bug 961863

    Change-Id: I213e23a150b4afaba1249584e8cb3b376095533e

Changed in horizon:
status: In Progress → Fix Committed
Devin Carlen (devcamcar) on 2012-03-22
Changed in horizon:
milestone: none → essex-rc2
Devin Carlen (devcamcar) on 2012-03-22
tags: removed: essex-rc-potential
Thierry Carrez (ttx) on 2012-04-03
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers