Column and Cell don't inherit from HTMLElement

Bug #960590 reported by Gabriel Hurley on 2012-03-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Medium
Gabriel Hurley

Bug Description

Because Column and Cell don't inherit from HTMLElement, they have different and arbitrary interfaces which makes them harder to work with and harder to customize.

Fix proposed to branch: master
Review: https://review.openstack.org/5586

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/5586
Committed: http://github.com/openstack/horizon/commit/8a10e8a5f9e83411dc2008639a6900f9ee6ee904
Submitter: Jenkins
Branch: master

commit 8a10e8a5f9e83411dc2008639a6900f9ee6ee904
Author: Gabriel Hurley <email address hidden>
Date: Tue Mar 20 13:49:38 2012 -0700

    Handle custom column classes; inherit from HTMLElement.

      * Fixes bug 960588, allowing custom (and mixed) column classes
        to be handled appropriately in the table metaclass.
      * Reworks Column and Cell to inherit from HTMLElement, making
        them both more consistent and easier to customize.
        Fixes bug 960590.

    Change-Id: I88ec6d8d66703f11c508b4c10af439e3b732b3ce

Changed in horizon:
status: In Progress → Fix Committed
Devin Carlen (devcamcar) on 2012-03-22
tags: removed: essex-rc-potential
Changed in horizon:
milestone: none → essex-rc2
Thierry Carrez (ttx) on 2012-04-03
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers