Redirect exceptions in tabs not handled correctly

Bug #955642 reported by Gabriel Hurley on 2012-03-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Critical
Gabriel Hurley

Bug Description

If an API method raises an exception inside the get_context_data method of a tab it is not caught by Horizon's middleware. This is due to the default deferred rendering done by Django's TemplateResponse class which manages to delay the rendering until after the final middleware has been processed.

Fix proposed to branch: master
Review: https://review.openstack.org/5382

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/5382
Committed: http://github.com/openstack/horizon/commit/b8754d5ecd12b29297d6462b18c2ffc0c3176d90
Submitter: Jenkins
Branch: master

commit b8754d5ecd12b29297d6462b18c2ffc0c3176d90
Author: Gabriel Hurley <email address hidden>
Date: Wed Mar 14 18:55:28 2012 -0700

    Updates Image Details page to match other details pages. Fixes bug 955625.

    While updating these, a bug was discovered in the tab exception handling
    which is also fixed by this patch. Fixes bug 955642.

    Also incorporates some cleanup on the other details pages so that
    they are all uniform and at their best.

    Additionally, added a command to run_tests.sh to update all the translation
    strings (./run_tests.sh -m or --makemessages).

    Updates translation files.

    Change-Id: I61287b91fb442f7343c2ddebfcc547dc559efbdf

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers