UI Issue: Confirmation dialogs have a cancel button without the "cancel" CSS class applied to them.

Bug #954515 reported by John Postlethwait on 2012-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Medium
John Postlethwait

Bug Description

Dialogs to confirm an action, such as deleting a volume, have a cancel button that does not have the "cancel" class applied to them. This means that these buttons may not look the same as other cancel buttons throughout the dashboards.

The confirm modal dialogs should all have their cancel buttons have the "cancel" css class applied to them.

Gabriel Hurley (gabriel-hurley) wrote :

This should be a one-line change to the template in horizon/templates/horizon/client_side/_modal.html

Changed in horizon:
importance: Undecided → Medium
milestone: none → essex-rc1
status: New → Confirmed
Changed in horizon:
assignee: nobody → John Postlethwait (john-postlethwait)

Fix proposed to branch: master
Review: https://review.openstack.org/5300

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/5300
Committed: http://github.com/openstack/horizon/commit/f7c0dd203dec019fe23203740d6859aa0643481c
Submitter: Jenkins
Branch: master

commit f7c0dd203dec019fe23203740d6859aa0643481c
Author: John Postlethwait <email address hidden>
Date: Tue Mar 13 15:18:34 2012 -0700

    Adding a cancel CSS class to confirmation modals so they can be styled individualls. Fixes Bug #954515

    Change-Id: I99ff5bc2252991216c47d4a9d95b420369f56966

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers