HTML replacement by AJAX polling interrupts actions

Bug #948432 reported by Gabriel Hurley on 2012-03-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Andy Chong

Bug Description

Trying to check the checkbox or select an action for a row that's in a polling state is very difficult since the polling causes the row to be replaced and interrupts the action. We need to detect whether the row is being interacted with (action menu open, checkbox checked, etc.) and pause the polling if it is.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → High
milestone: none → essex-rc1
status: New → Confirmed
Andy Chong (andycjw) on 2012-03-09
Changed in horizon:
assignee: Gabriel Hurley (gabriel-hurley) → Andy Chong (andycjw)

Fix proposed to branch: master
Review: https://review.openstack.org/5120

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/5120
Committed: http://github.com/openstack/horizon/commit/dfe55c00b6738e8f3b9ea904ed3efbe3ab45a379
Submitter: Jenkins
Branch: master

commit dfe55c00b6738e8f3b9ea904ed3efbe3ab45a379
Author: Andy Chong <email address hidden>
Date: Fri Mar 9 12:24:57 2012 +0800

    add progressive interval delay, extra checks in ajax row update polling

     * fix bug 948429, increase interval multiplier if row no update
     * fix bug 948432, with following changes
       * update row with replace only if html differs (changes found)
       * do not trigger ajax request if row action is expanded
       * still trigger ajax request if row checkbox is checked
         and the checkbox is remained checked if row replaced
     * fix bug 953268, see last point above

    Change-Id: I487407289305694025a555f1dc96317d17416307

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers