Instance dropdown displayed with no actions

Bug #948397 reported by Gabriel Hurley on 2012-03-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Medium
Gabriel Hurley

Bug Description

If a row has one normal action and an "update" action for the ajax updating, the dropdown is still displayed due to the "hidden" update action. This should be reworked to avoid showing the dropdown. This may mean not actually rendering the action in the list at all and instead adding the relevant data as a data attribute on the row or some such thing.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → Medium
milestone: none → essex-rc1
status: New → Confirmed
Andy Chong (andycjw) wrote :

and the dropdown is missing because the Table Action class doesn't allow empty table data for batch action
I added check for ajax request, and bypass this check for ajax request, and the action should now shows

Changed in horizon:
assignee: Gabriel Hurley (gabriel-hurley) → Andy Chong (andycjw)

Fix proposed to branch: master
Review: https://review.openstack.org/5008

Changed in horizon:
status: Confirmed → In Progress
summary: - Instance dropdown displayed with no actions when in error state
+ Instance dropdown displayed with no actions
description: updated
Changed in horizon:
assignee: Andy Chong (andycjw) → Gabriel Hurley (gabriel-hurley)

Fix proposed to branch: master
Review: https://review.openstack.org/5307

Reviewed: https://review.openstack.org/5307
Committed: http://github.com/openstack/horizon/commit/753ebd673c164cc0469a3de1b9ce40fefe92e99b
Submitter: Jenkins
Branch: master

commit 753ebd673c164cc0469a3de1b9ce40fefe92e99b
Author: Gabriel Hurley <email address hidden>
Date: Tue Mar 13 17:27:18 2012 -0700

    Moved ajax updating from Action to Row.

    This fixes the problem of having to "hide" the update action
    in the row's actions column. Fixes bug 948397.

    Additionally, added some protection for spillover between
    the attrs dictionary on action instances. Fixes bug 954592.

    FWIW, the code involved in the AJAX updating is largely identical,
    it's just been moved from Action to Row and had few data accessors
    renamed to account for the differing relation to Table and Row.
    This also allowed the javascript to be significantly cleaner.

    Change-Id: Ic8932a33ca6956a56c8eee09bb0a4d1f59e0ab3a

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers