Image attributes should not all be modifiable

Bug #944509 reported by Brian Waldon on 2012-03-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Medium
Andy Chong

Bug Description

I would expect container/disk_format not to be modifiable. I'm also thinking that architecture doesn't matter until Glance handles it: http://stsh.me/1Jh. This applies to Images and Image Snapshots.

Devin Carlen (devcamcar) wrote :

things can just be made read-only fields

Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → essex-rc1
Jim Yeh (lemonlatte) wrote :

I don't understand why shouldn't the kernel id and ramdisk id be editable?
Does it have any effect on the running instance?

Thanks for comment.

Andy Chong (andycjw) on 2012-03-02
Changed in horizon:
assignee: nobody → Andy Chong (andycjw)
Changed in horizon:
status: Confirmed → In Progress
Brian Waldon (bcwaldon) wrote :

Jim: kernel id and ramdisk id should be editable, but we should limit them to a list of known images with a disk_format of aki and ari, respectively.

Brian Waldon (bcwaldon) wrote :

To answer your question, yes, they handle how the machine image you have will boot.

Jim Yeh (lemonlatte) wrote :

I got it. Thank you very much.

Reviewed: https://review.openstack.org/4797
Committed: http://github.com/openstack/horizon/commit/0860680d3a9fe3450d6378dd7bdf3507c78ea460
Submitter: Jenkins
Branch: master

commit 0860680d3a9fe3450d6378dd7bdf3507c78ea460
Author: Andy Chong <email address hidden>
Date: Fri Mar 2 11:39:19 2012 +0800

    set image attributes not modifiable as read-only

     * fixes bug 944509

    Change-Id: Ib3319be474d71d6fe8f46263a43330d48180e889

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers