Form errors from modal should be handled in modal
Bug #943518 reported by
andrewsben
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Medium
|
Gabriel Hurley |
Bug Description
Don't know if this is done on purpose or not, but it is functional so I guess this would be a UX improvement thing...
If while launching an instance I don't include a required field, such as server name, the form redirects to a launch page instead of staying on the images page with the popup.
Steps:
Goto images page
select desired image and click launch.
hit submit without putting a server name
redirects to URL/nova/
Expected / Desired:
Stay on the same page keeping the nice look and refreshing the popup dialogue.
Changed in horizon: | |
assignee: | nobody → Emma Grace Steimann (emmasteimann) |
Changed in horizon: | |
status: | New → Confirmed |
importance: | Undecided → Low |
milestone: | none → essex-rc1 |
Changed in horizon: | |
milestone: | essex-rc1 → none |
Changed in horizon: | |
assignee: | Emma Grace Steimann (emmasteimann) → Andy Chong (andycjw) |
tags: | added: essex-rc-potential |
Changed in horizon: | |
assignee: | Andy Chong (andycjw) → Gabriel Hurley (gabriel-hurley) |
Changed in horizon: | |
milestone: | none → essex-rc2 |
tags: | removed: essex-rc-potential |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | essex-rc2 → 2012.1 |
To post a comment you must log in.
Hi,
I fixed this bug(943518).The changes are as follows.
In /horizon/ horizon/ horizon/ dashboards/ nova/templates/ nova/images_ and_snapshots/ images/ _launch. html file, we included one javascript that verifies whether server name field is empty or not.
If the field is empty, an error message is displayed stating that "Server Name field should not be empty". Textbox border will become "Red" color and background will become "Yellow".
Please let me know if anybody started working on this bug. If the work is not yet started on this bug, I will assign this bug to myself and check-in the code into repository.
The Java script is:
<script type="text/ javascript" > image_form. id_name; document. getElementById( 'error' ); .value == "")
errlabel. innerHTML = "Error : Server Name field can't be empty.";
launch_ image_form. id_name. style.border = "solid 1px red";
launch_ image_form. id_name. style.backgroun d = "yellow"
function check()
{
var textBoxField = launch_
var errlabel=
if(textBoxField
{
return false;
}
else
{
return true;
}
}
</script>
Thanks and Regards,
Anil.