Toggling behavior in BatchAction doesn't account for translations

Bug #932288 reported by Gabriel Hurley on 2012-02-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Critical
Gabriel Hurley

Bug Description

The _conjugate method does type checking against basestring to try and determine whether there are toggle choices it must select between or whether it can just use the string as is. However, lazy translation objects are not instances of basestring, they're instances of django.utils.functional.Promise.

Due to this, only one letter of an action verb is selected instead of the whole string.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → Critical
milestone: none → essex-4
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/4157

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/4157
Committed: http://github.com/openstack/horizon/commit/c689f19ca22ffc853560a1a53356c992bd4b41fa
Submitter: Jenkins
Branch: master

commit c689f19ca22ffc853560a1a53356c992bd4b41fa
Author: Gabriel Hurley <email address hidden>
Date: Tue Feb 14 12:31:13 2012 -0800

    Bugfixes for modify project users.

      * Fixes a 500 error when trying to access the modify users view,
        adds a unit test for that. Fixes bug 932270.
      * Fixes a problem in the way BatchAction conjugated action names
        that caused weird behavior. Fixes bug 932288.

    Change-Id: Ibf023513f51f3180adf6510833ee760915e7dd91

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers