Test isolation for Horizon base tests is broken

Bug #929983 reported by Gabriel Hurley on 2012-02-10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Gabriel Hurley

Bug Description

Because of the way the core Horizon object is constructed, stored, and referenced, changes to it, its registered dashboards, and its registered panels all persist across tests. This negates any ability to reliably test critical core functionality.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → Critical
milestone: none → essex-4
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/3997

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/3997
Committed: http://github.com/openstack/horizon/commit/aed4766cc95df806e2d0ac8053231cfe4687e149
Submitter: Jenkins
Branch: master

commit aed4766cc95df806e2d0ac8053231cfe4687e149
Author: Gabriel Hurley <email address hidden>
Date: Thu Feb 9 22:29:23 2012 -0800

    Full support for dashboard and panel configuration via service catalog.

    There are no longer any dependencies on settings for whether or not
    particular components are made available in the site.

    Implements blueprint toggle-features.

    Also fixes bug 929983, making the Horizon object a proper
    singleton and ensuring test isolation for the base horizon tests.

    Fixes a case where a missing service catalog would cause
    a 500 error. Fixes bug 930833,

    Change-Id: If19762afe75859e63aa7bd5128a6795655df2c90

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers