Login redirect doesn't work with modals

Bug #929309 reported by Paul McMillan on 2012-02-09
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Tihomir Trifonov

Bug Description

When a user would normally get redirected to the login screen, if they click a button that brings up a modal dialog, they are presented with an incorrect login screen within the modal. The entire page should reflect the login screen, rather than framing in the modal.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Devin Carlen (devcamcar) on 2012-02-20
Changed in horizon:
milestone: none → essex-4
Changed in horizon:
assignee: nobody → Tihomir Trifonov (ttrifonov)

Fix proposed to branch: master
Review: https://review.openstack.org/4601

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/4601
Committed: http://github.com/openstack/horizon/commit/e040ad12a0fd551ec28a4c5218a7069b2402805e
Submitter: Jenkins
Branch: master

commit e040ad12a0fd551ec28a4c5218a7069b2402805e
Author: Tihomir Trifonov <email address hidden>
Date: Mon Feb 27 20:45:57 2012 +0200

    Prevents unauth'd view calls from popping up login in modal window.

    Fixes bug 929309

    Note: The authentication logic is slightly changed -
    login_required decorator is replaced by a Horizon decorator,
    that raises NotAuthorized exception instead redirecting
    to login page. Then, all unauthorized requests are now
    handled by Horizon Middleware, and performs a check if
    the request is from ajax call(then returns error 401),
    otherwise - redirects to login page, persisting the
    requested page in ?next= variable.

    Change-Id: Ic90658bff2eabfe630b1f9912cf4a5aa45edf58e

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers