Terminate Button Shows When There Are No Instances

Bug #925671 reported by Ronald Petty on 2012-02-02
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Undecided
Mike Perez

Bug Description

Steps to reproduce:
1) Login admin using FF 3.6.13
2) Nav to http://192.168.56.101/syspanel/instances/

Expected behavior: "Terminate Instances" is disabled when no instances are running
Actual behavior: "Terminate Instances" is enabled when no instances are running

Example:
http://c213515.r15.cf1.rackcdn.com/f344b9cb54ded8d5f28d814b03d6467a.png

Mike Perez (thingee) on 2012-02-02
Changed in horizon:
status: New → Confirmed
assignee: nobody → Mike Perez (thingee)

Fix proposed to branch: master
Review: https://review.openstack.org/3715

Changed in horizon:
status: Confirmed → In Progress
Mike Perez (thingee) wrote :

Ah just noticed Gabriel's comment on the review. Gabriel, thanks for pointing me out to a better solution that's a lot easier than what I was doing for each batchaction. Sorry for the slow update guys, I'll have something in today!

Mike Perez (thingee) wrote :

I brought up to Tres and Gabriel if the following would work:

https://github.com/Thingee/horizon/commit/fcafc75a585bbf5e50bebc0c67c87407cf6666b0

Tres mentioned that it should probably be fixed in the constructor. Gabriel, can you let me know where exactly you need this taken care from your in gerrit? Thanks everyone for the help!

Fix proposed to branch: master
Review: https://review.openstack.org/4354

Reviewed: https://review.openstack.org/4354
Committed: http://github.com/openstack/horizon/commit/8cfd57b98e07ce222b21aca2ec493a2b3f3852a5
Submitter: Jenkins
Branch: master

commit 8cfd57b98e07ce222b21aca2ec493a2b3f3852a5
Author: Mike Perez <email address hidden>
Date: Fri Feb 17 20:56:28 2012 -0800

    don't show batch actions if no table data is available

    bug 925671

    Change-Id: I5e97d059f6f02f033f8dfb9aede01de75e514c98

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in horizon:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers