Keypair file when name has space is not complete on download

Bug #900528 reported by andrewsben on 2011-12-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Gabriel Hurley

Bug Description

When I created a new keypair with a space in the name the download it provides is named with the value before the space only. E.g. "ben test" results in a private key download called "ben".

Steps:
Navigate to keypairs
Select "create new keypair"
in keypair name, provide name with space.
Click create keypair.
provides download with only the first part of the name and no extension.

Expected:
private key download to replace spaces with safe characters ( - or _ ) and to have the pem extension.

Gabriel Hurley (gabriel-hurley) wrote :

Yep, firefox doesn't handle spaces in attachment names well.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
status: New → In Progress
Devin Carlen (devcamcar) on 2011-12-09
Changed in horizon:
milestone: none → essex-2
importance: Undecided → Low

Reviewed: https://review.openstack.org/2236
Committed: http://github.com/openstack/horizon/commit/75bff6914dcb2ff2b792dd6f06bbe69f6afc9f41
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 75bff6914dcb2ff2b792dd6f06bbe69f6afc9f41
Author: Gabriel Hurley <email address hidden>
Date: Fri Dec 9 12:26:08 2011 -0800

    Keypair bugfixes.

    Corrects keypair name validation and prevents illegal characters in
    header name. Fixes bug 900528.

    Fixes location of "refresh this page" message insertion to match
    other messages.

    Ensures that deletion of keypairs gets a confirmation dialog box.

    Change-Id: I99d70dd21c840320ef3fc6a246d283cef5b7a64a

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2011-12-14
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers