Keypairs names with non-URL-safe characters can't be deleted

Bug #898803 reported by Gabriel Hurley on 2011-12-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Undecided
Gabriel Hurley

Bug Description

The way novaclient sends back the keypair deletion request, it inserts the keypair name directly into the URL. This means very common characters like spaces cause malformed requests and fail at deletion. Moreover, an false positive "success" message is returned saying the keypair has been deleted when it hasn't.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
status: New → Confirmed

Reviewed: https://review.openstack.org/2020
Committed: http://github.com/openstack/horizon/commit/eb896725004283ab53047735dcd308fd934acdd7
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit eb896725004283ab53047735dcd308fd934acdd7
Author: Gabriel Hurley <email address hidden>
Date: Thu Dec 1 12:59:31 2011 -0800

    Added urlquote call around keypair name in delete form. Fixed bug 898803.

    Change-Id: Ie39c0c9136a2b02247a4e67a16d91ef09c2e5ddc

Changed in horizon:
status: Confirmed → Fix Committed
Thierry Carrez (ttx) on 2011-12-14
Changed in horizon:
milestone: none → essex-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in horizon:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers