project managers should be able to modify image attributes of an image belonging to the project
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
High
|
Gabriel Hurley |
Bug Description
There were some problems with the image detail UI showing edit controls even if the user didn't have rights to modify the image. Nova still prevented the operation, but the UI was giving the option to incorrectly.
The attached diff was the hotfix of this issue. Further logic is needed to check to see if the signed in user is a project manager of the current project in context. In this case, the project manager should be able to modify the image.
Essentially:
IF request.user is projectmanager of image
OR request.user is image.ownerId
However, one place image.ownerId was referenced as a user ID, and another it was referenced as a project ID. We need to find out which it is to properly fix this bug.
Changed in openstack-dashboard: | |
status: | New → Confirmed |
Changed in horizon: | |
milestone: | none → essex-3 |
Changed in horizon: | |
milestone: | essex-3 → essex-4 |
Changed in horizon: | |
milestone: | 2012.1 → essex-rc1 |
Changed in horizon: | |
assignee: | Devin Carlen (devcamcar) → Nebula (nebula) |
Changed in horizon: | |
milestone: | essex-rc1 → none |
Changed in horizon: | |
assignee: | Nebula (nebula) → Gabriel Hurley (gabriel-hurley) |
milestone: | none → essex-rc1 |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | essex-rc1 → 2012.1 |
Perhaps the decision on if the edit can occur will be based on RBAC ruleset?