objectstore swift change container pubic access doesn't work

[Robert Jansen]

On OpenStack Horizon 2023.1, after a container is created it is no longer possible to change the Public Access.

Steps to reproduce:

Log in to horizon
Create a new container and make it Public
select the container in horizon
uncheck the "Public Access" button
A message is displayed stating the change was successfull
The checkmark returns to its old position (and the container is still public

Due to a change in anglerjs (https://docs.angularjs.org/guide/migration#-input-radio-and-input-checkbox-) input[radio] and input[checkbox] now listen to the "change" event instead of the "click" event.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/horizon/+/884596

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/884545

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/horizon/+/884546

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/884546
Committed: https://opendev.org/openstack/horizon/commit/4f0d4d161a7761f3c6e291dae882233a6cc2a301
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 4f0d4d161a7761f3c6e291dae882233a6cc2a301
Author: Michel Nederlof <email address hidden>
Date: Tue May 30 16:17:01 2023 +0200

    Fix object-store container toggle for turning public access on/off

    After updating to angular 1.8, changes to a object (in this case the
    container object) has changed from the click event to the onchange event
    for input radio's and checkboxes as described on
    https://docs.angularjs.org/guide/migration#-input-radio-and-input-checkbox-

    In our scenario this means the container.is_public value is changed
    _after_ the ajax call went to the horizon API, effectively not changing it.

    This change fixes this, by migrating to the ng-change event for this toggle

    Closes-Bug: #2020879
    Change-Id: If3b87da6d747bb7e738b64f4c2f3472a7556c652

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/884545
Committed: https://opendev.org/openstack/horizon/commit/cd64730ee4f560016363f4e05b176dac4e678757
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit cd64730ee4f560016363f4e05b176dac4e678757
Author: Michel Nederlof <email address hidden>
Date: Tue May 30 16:17:01 2023 +0200

    Fix object-store container toggle for turning public access on/off

    After updating to angular 1.8, changes to a object (in this case the
    container object) has changed from the click event to the onchange event
    for input radio's and checkboxes as described on
    https://docs.angularjs.org/guide/migration#-input-radio-and-input-checkbox-

    In our scenario this means the container.is_public value is changed
    _after_ the ajax call went to the horizon API, effectively not changing it.

    This change fixes this, by migrating to the ng-change event for this toggle

    Closes-Bug: #2020879
    Change-Id: If3b87da6d747bb7e738b64f4c2f3472a7556c652

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.0.1 release.