qos and trunks does not show any entries

[Tomas Leypold]

Horizon Zed does not show any entries in "network/network qos" and "network/trunks" it just shows "No items to display" and there is an error in the browser console:

TypeError: Cannot read properties of undefined (reading 'data')
    at modifyResponse (output.2f23aa85dea9.js:868:63)
    at processQueue (output.c0c52d1d8fb8.js:1581:786)
    at output.c0c52d1d8fb8.js:1585:110
    at Scope.$digest (output.c0c52d1d8fb8.js:1636:200)
    at Scope.$apply (output.c0c52d1d8fb8.js:1643:269)
    at done (output.c0c52d1d8fb8.js:1356:123)
    at completeRequest (output.c0c52d1d8fb8.js:1375:20)
    at XMLHttpRequest.requestLoaded (output.c0c52d1d8fb8.js:1368:1) 'Possibly unhandled rejection: {}'
(

TypeError: Cannot read properties of undefined (reading 'data')
    at addTrackBy (output.5e3096d425c4.js:1114:59)
    at processQueue (output.989d06bb6631.js:1469:260)
    at output.989d06bb6631.js:1470:135
    at Scope.$eval (output.989d06bb6631.js:1516:549)
    at Scope.$digest (output.989d06bb6631.js:1510:200)
    at Scope.$apply (output.989d06bb6631.js:1517:277)
    at done (output.989d06bb6631.js:1244:123)
    at completeRequest (output.989d06bb6631.js:1259:20)
    at XMLHttpRequest.requestLoaded (output.989d06bb6631.js:1253:1)
(

With CLI everything works just fine:

$ openstack network qos policy list
+--------------------------------------+---------+--------+---------+----------------------------------+
| ID | Name | Shared | Default | Project |
+--------------------------------------+---------+--------+---------+----------------------------------+
| 01d40d01-45b0-404f-8064-06d502baaeae | test01 | False | False | f5b9d6bf68184e3da8aaebef2d4804be |
| 549420b8-9562-474c-a02c-3910866eb145 | test02 | True | False | f5b9d6bf68184e3da8aaebef2d4804be |
| 5f5194c2-4b98-4d26-8021-74a5c8a93e27 | test03 | False | False | f5b9d6bf68184e3da8aaebef2d4804be |
+--------------------------------------+---------+--------+---------+----------------------------------+

Tested on kolla-asible Zed (Ubuntu 22.04) and packstack Zed (CentOS Stream 9) both with the same result.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/horizon/+/882744

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882744
Committed: https://opendev.org/openstack/horizon/commit/c770785dcf6cb9d79ae26986ce5156e4ddc0f534
Submitter: "Zuul (22348)"
Branch: master

commit c770785dcf6cb9d79ae26986ce5156e4ddc0f534
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue May 9 14:04:35 2023 -0500

    Fix qos and trunks tables

    When replacing deprecated custom callback methods success()/error()
    with then()/catch(), we need to keep in mind that methods' signatures
    and return values are different, so we need to explicitly return the
    response value when using then(function onSuccess(response){}).

    Closes-Bug: #2018232

    Change-Id: I9d6d769075753c6395db2530a8d60ec28cafdc3d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/horizon/+/882777

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/882780

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882777
Committed: https://opendev.org/openstack/horizon/commit/24c655379274b159e9ed543b8eeb976667a1cb7a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 24c655379274b159e9ed543b8eeb976667a1cb7a
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue May 9 14:04:35 2023 -0500

    Fix qos and trunks tables

    When replacing deprecated custom callback methods success()/error()
    with then()/catch(), we need to keep in mind that methods' signatures
    and return values are different, so we need to explicitly return the
    response value when using then(function onSuccess(response){}).

    Closes-Bug: #2018232

    Change-Id: I9d6d769075753c6395db2530a8d60ec28cafdc3d
    (cherry picked from commit c770785dcf6cb9d79ae26986ce5156e4ddc0f534)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882780
Committed: https://opendev.org/openstack/horizon/commit/c35d8f1c11ac283759ed2a5c1d4d19239002fb30
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c35d8f1c11ac283759ed2a5c1d4d19239002fb30
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue May 9 14:04:35 2023 -0500

    Fix qos and trunks tables

    When replacing deprecated custom callback methods success()/error()
    with then()/catch(), we need to keep in mind that methods' signatures
    and return values are different, so we need to explicitly return the
    response value when using then(function onSuccess(response){}).

    Closes-Bug: #2018232

    Change-Id: I9d6d769075753c6395db2530a8d60ec28cafdc3d
    (cherry picked from commit c770785dcf6cb9d79ae26986ce5156e4ddc0f534)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.0.1 release.