Description of Image in metadata is overwritten by description of Image in Image Details

Bug #2017698 reported by Tatiana Ovchinnikova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Tatiana Ovchinnikova

Bug Description

We have two places to edit image definition: one in Edit Image -> Image Detail section, and another is in Edit Image -> Metadata. If the definition is empty, it doesn't appear in Metadata section, but if it is not, we have two places to edit it, and the one from Image Detail overwrites the one from Metadata (even if you delete it from Metadata).

Changed in horizon:
importance: Undecided → Low
assignee: nobody → Tatiana Ovchinnikova (tmazur)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/horizon/+/881514

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/881514
Committed: https://opendev.org/openstack/horizon/commit/283b38e4f10b14c61dff42936c80ae3987f017cf
Submitter: "Zuul (22348)"
Branch: master

commit 283b38e4f10b14c61dff42936c80ae3987f017cf
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/horizon/+/882296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/horizon/+/882402

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/horizon/+/882403

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/horizon/+/882404

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/882511

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882511
Committed: https://opendev.org/openstack/horizon/commit/d643547ed6f74d5d0372df47b6ac736e33486212
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d643547ed6f74d5d0372df47b6ac736e33486212
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
    (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882403
Committed: https://opendev.org/openstack/horizon/commit/e2510625ca27f2747396b4b766667715ade85e18
Submitter: "Zuul (22348)"
Branch: stable/xena

commit e2510625ca27f2747396b4b766667715ade85e18
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
    (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882402
Committed: https://opendev.org/openstack/horizon/commit/b8e1bc23abee85a77545ea9350179a42a6c757a6
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit b8e1bc23abee85a77545ea9350179a42a6c757a6
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
    (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)

tags: added: in-stable-yoga
tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882296
Committed: https://opendev.org/openstack/horizon/commit/b2a9046fb52e65725134f5e92dae01dd6eb3e4d4
Submitter: "Zuul (22348)"
Branch: stable/zed

commit b2a9046fb52e65725134f5e92dae01dd6eb3e4d4
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
    (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/882404
Committed: https://opendev.org/openstack/horizon/commit/c10e381f428a3c77ee11a2a5c14dca2c3e439eea
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c10e381f428a3c77ee11a2a5c14dca2c3e439eea
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Apr 25 15:17:43 2023 -0500

    Remove Description from Edit Image Metadata

    Image description can be edited through Edit Image -> Image Detail,
    however it also appears as a property in Edit Image -> Metadata when
    the description is not empty. It's confusing to have it in two sections
    of one dialog form, and moreover, the Image Detail field always
    overwrites the Metadata field.

    This patch removes Description from Edit Metadata.

    Closes-Bug: #2017698

    Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
    (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 23.2.0

This issue was fixed in the openstack/horizon 23.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 22.1.1

This issue was fixed in the openstack/horizon 22.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 23.0.1

This issue was fixed in the openstack/horizon 23.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon wallaby-eom

This issue was fixed in the openstack/horizon wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon xena-eom

This issue was fixed in the openstack/horizon xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.