Checkbox "Set admin password" always is visible

[Denis Nurislamov]

Hello,

Options in local_settings not working correctly.

OPENSTACK_HYPERVISOR_FEATURES{
'can_set_password': False,
}

When we create instance we always see field "Set admin password" in Key Pair menu.

If file

https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/keypair.html#L29

replace

<settings-service required-settings='["OPENSTACK_HYPERVISOR_FEATURES.can_set_password"]'>

to

<settings-service hz-if-settings='["OPENSTACK_HYPERVISOR_FEATURES.can_set_password"]'>

fixit it.

Testing OS Releases:
Wallaby,Xena,Yoga

Centos8-Stream

Thank you,
Den Nu

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/horizon/+/851258

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/851258
Committed: https://opendev.org/openstack/horizon/commit/dd7faaa0231972b09d264b0ccc09e51f26a5fb12
Submitter: "Zuul (22348)"
Branch: master

commit dd7faaa0231972b09d264b0ccc09e51f26a5fb12
Author: Tatiana Ovchinnikova <email address hidden>
Date: Wed Jul 27 15:20:23 2022 -0500

    Fix "Set admin password" checkbox visibility

    The checkbox should only be visible when 'can_set_password' is True.

    Closes-Bug: #1976445

    Change-Id: I887c4fcbccc6af77203d2b2bdb4f016fd9725f6c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 22.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 23.0.1 release.