Validation on fails on the Associate Floating IP when too many instances exist

[Radomir Dopieralski]

If there are more than Nova's pagination limit instances, and one tries to associate a floating IP with a new instance, the form's validation will fail.

This is because that form populates the drop-down field for association target differently on initial display of the form (where it takes the instance_id from the URL) than on submitting of that form (when the information from the URL is lost). The latter attempts to get all eligible ports, but is limited by Nova's pagination.

You can also observe weird behavior when that form has any error (for instance, because the floating IP wasn't selected) — after submitting, it will re-display the form with the error, but now the target drop-down will be populated with all possible ports, instead of only ones on the instance, like on the initial display.

[Vishal Manchanda (vishalmanchanda)]

It is fixed by https://review.opendev.org/c/openstack/horizon/+/780925.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 19.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/782421
Committed: https://opendev.org/openstack/horizon/commit/8e69282bf4491a1a49bd0d0cc05bbaf835095998
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 8e69282bf4491a1a49bd0d0cc05bbaf835095998
Author: Radomir Dopieralski <email address hidden>
Date: Tue Mar 16 17:09:21 2021 +0100

    Save instace_id inside Associate Floating IP workflow

    Also, rename instance_id field to proper port_id.

    Before this change, when instance_id was passed from the Instances
    page in the URL, the information would be lost on form submission,
    and if the form contained an error, the it would be redisplayed with
    the port drop-down containing all ports from all instances. This also
    made submitting this form slow, as the drop-down would be populated
    with all ports on form validation.

    It also creates a bug, where if there are more instances than Nova's
    pagination allows, the ports from newer instances would no longer
    appear in the drop-down, and the form would fail to validate, even
    though the choice of port on initial form was correct.

    Closes-bug: #1920010
    Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb
    (cherry picked from commit 3d82d57353d1a29fb5b568ffaa93db86998e9d94)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/782422
Committed: https://opendev.org/openstack/horizon/commit/64024e9f52be6fa16c27697fec852f38c6ae2816
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 64024e9f52be6fa16c27697fec852f38c6ae2816
Author: Radomir Dopieralski <email address hidden>
Date: Tue Mar 16 17:09:21 2021 +0100

    Save instace_id inside Associate Floating IP workflow

    Also, rename instance_id field to proper port_id.

    Before this change, when instance_id was passed from the Instances
    page in the URL, the information would be lost on form submission,
    and if the form contained an error, the it would be redisplayed with
    the port drop-down containing all ports from all instances. This also
    made submitting this form slow, as the drop-down would be populated
    with all ports on form validation.

    It also creates a bug, where if there are more instances than Nova's
    pagination allows, the ports from newer instances would no longer
    appear in the drop-down, and the form would fail to validate, even
    though the choice of port on initial form was correct.

    Closes-bug: #1920010
    Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb
    (cherry picked from commit 3d82d57353d1a29fb5b568ffaa93db86998e9d94)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/782423
Committed: https://opendev.org/openstack/horizon/commit/2d2f944e2fe127433f2973ef77ba86ec997cf434
Submitter: "Zuul (22348)"
Branch: stable/train

commit 2d2f944e2fe127433f2973ef77ba86ec997cf434
Author: Radomir Dopieralski <email address hidden>
Date: Tue Mar 16 17:09:21 2021 +0100

    Save instace_id inside Associate Floating IP workflow

    Also, rename instance_id field to proper port_id.

    Before this change, when instance_id was passed from the Instances
    page in the URL, the information would be lost on form submission,
    and if the form contained an error, the it would be redisplayed with
    the port drop-down containing all ports from all instances. This also
    made submitting this form slow, as the drop-down would be populated
    with all ports on form validation.

    It also creates a bug, where if there are more instances than Nova's
    pagination allows, the ports from newer instances would no longer
    appear in the drop-down, and the form would fail to validate, even
    though the choice of port on initial form was correct.

    Closes-bug: #1920010
    Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb
    (cherry picked from commit 3d82d57353d1a29fb5b568ffaa93db86998e9d94)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 20.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 18.3.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 18.6.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon train-eol release.