Unable to override color of even lines in horizon tables

Bug #1900863 reported by Sébastien Gremion
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Unassigned

Bug Description

I'm trying to define a black theme for the Horizon dashboard and I managed to do most of the work by overriding scss variables in my theme. However I can't change the even lines of the instance table. They remain black whatever I put in the variable $table-bg-even

To reproduce :

1) Create a theme and try to override the variable $table-bg-even with #ff5050
2) Deploy the theme
3) Open the instances panel with at least two VMs
4) The even lines remain white instead of red

Possible root cause :

I think that this is caused by the missing "!default" next to $table-bg-even in the file /static/dashboard/scss/_variables.scss

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I confirmed the issue.
The possible root cause mentioned looks correct. I confirmed the background color of the even line of the table can be configured using a theme after adding !default to $table-bg-even. In addition, there is no reason to have a different thing in $table-bg-odd and $table-bg-even.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 19.1.0

This issue was fixed in the openstack/horizon 19.1.0 release.

Changed in horizon:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.