LAUNCH_INSTANCE_DEFAULTS does not work

[Akihiro Motoki]

Even after any parameter is configured in LAUNCH_INSTANCE_DEFAULTS setting in local_settings.py, it does not affect the launch instance form.
For example, 'create_volume' in LAUNCH_INSTANCE_DEFAULTS is set to False, "Create New Volume" in the "Source" tab in the launch instance form is not set to "No".

[Akihiro Motoki (amotoki)]

It is also reported in http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016776.html

[Akihiro Motoki (amotoki)]

It looks fixed in the master branch in https://review.opendev.org/#/c/746265/.
This bug was introduced when openstack_dashboard/defaults.py was introduced in Train cycle.
It affects train and ussuri.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/748133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/748134

[Akihiro Motoki (amotoki)]

It was fixed by https://review.opendev.org/#/c/746265/ in the master branch, so I am marking this as Fix Released.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748134
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e966e0f38a0180033cca6ede0ffb54c44cca7874
Submitter: Zuul
Branch: stable/train

commit e966e0f38a0180033cca6ede0ffb54c44cca7874
Author: chenxing <email address hidden>
Date: Fri Aug 14 11:47:54 2020 +0800

    Add miss comma of "REST_API_REQUIRED_SETTINGS" list

    Closes-Bug: #1892990
    Change-Id: I1eae4be4464f55a29d169403a70c958c3b8a308b
    (cherry picked from commit df5bf93138d9890b5bebbc835d174ef6ae610f24)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748133
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=44286f60319c8cfaa448f8f3abeca199294fdb02
Submitter: Zuul
Branch: stable/ussuri

commit 44286f60319c8cfaa448f8f3abeca199294fdb02
Author: chenxing <email address hidden>
Date: Fri Aug 14 11:47:54 2020 +0800

    Add miss comma of "REST_API_REQUIRED_SETTINGS" list

    Closes-Bug: #1892990
    Change-Id: I1eae4be4464f55a29d169403a70c958c3b8a308b
    (cherry picked from commit df5bf93138d9890b5bebbc835d174ef6ae610f24)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 16.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 18.3.3 release.