[Horizon]: After deleting multiple instances, could not able to see all remaining instances until i refresh instances list again.

[prashantingale]

Release : Stein (horizon-15.0.0,15.1.1)
Operating System : ubuntu

Issue : After deleting multiple instances, could not able to see all remaining instances until i refresh instances list again.

Reproduction Steps:

 1) create 10 (can take any number) instances.
 2) select multiple instances for delete. suppose we selected 4 instances.
 3) after deleting remaining instance list should show 6 instances but it will not show all.
 4) for seeing all instances again need to click instance tab from horizon.

observation:
   This issue is not seen in rocky(horizon 14.0.0).

[prashantingale (prashantingale)]

it seems that this bug is occure due to below patch
https://github.com/openstack/horizon/commit/467669417979ec7443d5195d4b4635d5596cdc08

[Arif Ali (arif-ali)]

Hi, we see a similar or same issue in Ussuri too

scenario 1

1. Create 10 instance
2. Delete the last instance in the list
3. Once deleted, you will see list which is empty
4. refresh page, and you will see all of the remaining instances

scenario 2

1. create 10 instances
2. delete the 4 and 5th instance
3. once delete, the page will come back with the instance below the 5th instance. The first 3 instances will not show
4. refresh page, and you will see all of the remaining instances

My environment was as below

Openstack: Ussuri
series: bionic

dpkg -l | grep dashboard
ii heat-dashboard-common 3.0.0-0ubuntu0.20.04.1~cloud0 all OpenStack orchestration service - Common files
ii openstack-dashboard 3:18.3.2-0ubuntu0.20.04.1~cloud0 all Django web interface for OpenStack
ii openstack-dashboard-common 3:18.3.2-0ubuntu0.20.04.1~cloud0 all Django web interface for OpenStack - common files
ii openstack-dashboard-ubuntu-theme 3:18.3.2-0ubuntu0.20.04.1~cloud0 all Transitional dummy package for Ubuntu theme for Horizon
ii python3-designate-dashboard 10.0.0-0ubuntu0.20.04.1~cloud0 all OpenStack DNS as a Service - Python 3 dashboard plugin
ii python3-heat-dashboard 3.0.0-0ubuntu0.20.04.1~cloud0 all OpenStack orchestration service - Python 3 dashboard plugin
ii python3-neutron-fwaas-dashboard 1:3.0.0-0ubuntu0.20.04.1~cloud0 all OpenStack Firewall as a Service - dashboard plugin

[Piotr Parczewski (parczewski)]

Victoria is affected too - moreover, it's enough to delete one from the multiple instances to reproduce.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Heather Lemon <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/horizon/+/788564
Reason: confusion from master to wallaby series

[Heather Lemon (hypothetical-lemon)]

yeah still working on this. There are some failing unit tests that need fixed first.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/788585
Committed: https://opendev.org/openstack/horizon/commit/c90c0b709c170fae299acc5917e7da69fb2ef2a8
Submitter: "Zuul (22348)"
Branch: master

commit c90c0b709c170fae299acc5917e7da69fb2ef2a8
Author: Heather Lemon <email address hidden>
Date: Wed Apr 28 07:56:52 2021 -0600

    Fix instance table behavior after deleting an instance

    After deleting a VM from the instances table,
    all VMs above it in the table list disappear from the
    UI until the page is refreshed.

    Partial-Bug: #1859851

    Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/horizon/+/872585

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/horizon/+/872586

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/horizon/+/872587

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/872585
Committed: https://opendev.org/openstack/horizon/commit/13824f3af96ac9102882870ac828daa914eb7fd2
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 13824f3af96ac9102882870ac828daa914eb7fd2
Author: Heather Lemon <email address hidden>
Date: Wed Apr 28 07:56:52 2021 -0600

    Fix instance table behavior after deleting an instance

    After deleting a VM from the instances table,
    all VMs above it in the table list disappear from the
    UI until the page is refreshed.

    Partial-Bug: #1859851

    Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677
    (cherry picked from commit c90c0b709c170fae299acc5917e7da69fb2ef2a8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/872586
Committed: https://opendev.org/openstack/horizon/commit/f3a6f2bd800a2c6aff577f0e0e14c3e6c326be6c
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f3a6f2bd800a2c6aff577f0e0e14c3e6c326be6c
Author: Heather Lemon <email address hidden>
Date: Wed Apr 28 07:56:52 2021 -0600

    Fix instance table behavior after deleting an instance

    After deleting a VM from the instances table,
    all VMs above it in the table list disappear from the
    UI until the page is refreshed.

    Partial-Bug: #1859851

    Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677
    (cherry picked from commit c90c0b709c170fae299acc5917e7da69fb2ef2a8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/872587
Committed: https://opendev.org/openstack/horizon/commit/c2390030559357519e5a05c74becd6f35e568957
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c2390030559357519e5a05c74becd6f35e568957
Author: Heather Lemon <email address hidden>
Date: Wed Apr 28 07:56:52 2021 -0600

    Fix instance table behavior after deleting an instance

    After deleting a VM from the instances table,
    all VMs above it in the table list disappear from the
    UI until the page is refreshed.

    Partial-Bug: #1859851

    Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677
    (cherry picked from commit c90c0b709c170fae299acc5917e7da69fb2ef2a8)