OpenStack Dashboard (Horizon)

Cloud-shell and console break in websockify 0.9.0

Bug #1847889 reported by hongbin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
hongbin
Zun UI
New
Critical
hongbin
python-zunclient
Fix Released
Undecided
hongbin

Bug Description

Starting from websockify 0.9.0, it rejected text frame: https://github.com/novnc/websockify/commit/8eb5cb0cdcd1314d6d763df8f226b587a2396aa2 . We have to send binary frame instead.

This affect CLI client (i.e. python-zunclient) and browser websocket client (i.e. zun-ui)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.opendev.org/688290

Changed in horizon:
assignee: nobody → hongbin (hongbin034)
status: New → In Progress
Changed in python-zunclient:
assignee: nobody → hongbin (hongbin034)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-zunclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/688291

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-zunclient (master)

Reviewed: https://review.opendev.org/688291
Committed: https://git.openstack.org/cgit/openstack/python-zunclient/commit/?id=bc1cfd9737380a4827fec97152139e6c2e918f38
Submitter: Zuul
Branch: master

commit bc1cfd9737380a4827fec97152139e6c2e918f38
Author: Hongbin Lu <email address hidden>
Date: Sun Oct 13 02:56:11 2019 +0000

    Send binary to websocket proxy

    Websockify 0.9.0 rejected receiving text frame:
    https://github.com/novnc/websockify/commit/8eb5cb0cdcd1314d6d763df8f226b587a2396aa2
    We have to switch to binary frame instead.

    Change-Id: Ie1525c673104588760ec78a3c996103da08b42d1
    Closes-Bug: #1847889

Changed in python-zunclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-zunclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/688302

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-zunclient (stable/train)

Reviewed: https://review.opendev.org/688302
Committed: https://git.openstack.org/cgit/openstack/python-zunclient/commit/?id=2ab88791f9890517b10a939eb0a5a9393c9f366e
Submitter: Zuul
Branch: stable/train

commit 2ab88791f9890517b10a939eb0a5a9393c9f366e
Author: Hongbin Lu <email address hidden>
Date: Sun Oct 13 02:56:11 2019 +0000

    Send binary to websocket proxy

    Websockify 0.9.0 rejected receiving text frame:
    https://github.com/novnc/websockify/commit/8eb5cb0cdcd1314d6d763df8f226b587a2396aa2
    We have to switch to binary frame instead.

    Change-Id: Ie1525c673104588760ec78a3c996103da08b42d1
    Closes-Bug: #1847889
    (cherry picked from commit bc1cfd9737380a4827fec97152139e6c2e918f38)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-zunclient 3.6.0

This issue was fixed in the openstack/python-zunclient 3.6.0 release.

hongbin (hongbin034)
Changed in zun-ui:
assignee: nobody → hongbin (hongbin034)
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.opendev.org/688290
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ea2212ebe59567d8ea21778cff5128e1029be045
Submitter: Zuul
Branch: master

commit ea2212ebe59567d8ea21778cff5128e1029be045
Author: Hongbin Lu <email address hidden>
Date: Sun Oct 13 02:51:53 2019 +0000

    Send binary frame in websocket client

    Websockify 0.9.0 rejected receiving text frame:
    https://github.com/novnc/websockify/commit/8eb5cb0cdcd1314d6d763df8f226b587a2396aa2
    We have to switch to binary frame instead.

    Change-Id: I2677b8879ccb27def22126811c347d5c08f5aada
    Closes-Bug: #1847889

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-zunclient 3.5.1

This issue was fixed in the openstack/python-zunclient 3.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/699077

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 17.1.0

This issue was fixed in the openstack/horizon 17.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/train)

Reviewed: https://review.opendev.org/699077
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6443c4f83d53500f6f5465adddf202eb76ce83f5
Submitter: Zuul
Branch: stable/train

commit 6443c4f83d53500f6f5465adddf202eb76ce83f5
Author: Hongbin Lu <email address hidden>
Date: Sun Oct 13 02:51:53 2019 +0000

    Send binary frame in websocket client

    Websockify 0.9.0 rejected receiving text frame:
    https://github.com/novnc/websockify/commit/8eb5cb0cdcd1314d6d763df8f226b587a2396aa2
    We have to switch to binary frame instead.

    Change-Id: I2677b8879ccb27def22126811c347d5c08f5aada
    Closes-Bug: #1847889
    (cherry picked from commit ea2212ebe59567d8ea21778cff5128e1029be045)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 16.1.0

This issue was fixed in the openstack/horizon 16.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.