Moving get_page_size from horizon to openstack_dashboard breaks many horizon plugins

[Akihiro Motoki]

Commit 7c897b677cc4e7eb11d90fce448160c2b90d1ef4 (which was merged yesterday, Sep 13) moved horizon.utils.functions.get_page_size to openstack_dashboard.utils.settings as it is specific to openstack_dashboard.
However, it turns out this change breaks many horizon plugins as they calls get_page_size() to determine the size of pagination in their API calls.

[Akihiro Motoki (amotoki)]

According to the codesearch [1], the following plugins are affected.

- murano-dashboard
- monasca-ui
- sahara-dashboard
- adjutant-ui
- freezer-web-ui
- heat-dashboard
- karbor-dashboard
- masakari-dashboard
- mistral-dashboard
- senlin-dashboard
- trove-dashboard

[1] http://codesearch.openstack.org/?q=get_page_size&i=nope&files=&repos=

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/681995

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681995
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cd1009bd2f3d6a6ee6e1d00e3733bb9964bb1903
Submitter: Zuul
Branch: master

commit cd1009bd2f3d6a6ee6e1d00e3733bb9964bb1903
Author: Akihiro Motoki <email address hidden>
Date: Fri Sep 13 17:38:00 2019 +0900

    Restore horizon.utils.functions.get_page_size()

    Commit 7c897b677cc4e7eb11d90fce448160c2b90d1ef4 moved get_page_size
    function from horizon.utils.functions to openstack_dashboard.utils.settings
    (as it is referred by the OpenStack API wrapper).

    However, it turns out that many horizon plugins calls the function
    and the above commit breaks horizon plugins.

    Considering we are in the last stage of Train development cycle,
    this commit restores horizon.utils.functions.get_page_size()
    to recover horizon plugins.

    Change-Id: I61be648b04ab0320a8c03b769e28ed74bbd242a1
    Closes-Bug: #1843871

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 16.0.0.0b2 development milestone.