error in floating IP allocation rest call

[Sam Morrison]

Getting the following error when POSTing to network/floatingip/

[Thu Jun 06 23:24:09.770231 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] ERROR openstack_dashboard.api.rest.utils error invoking apiclient
[Thu Jun 06 23:24:09.770306 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] Traceback (most recent call last):
[Thu Jun 06 23:24:09.770315 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] File "/usr/lib/python3/dist-packages/openstack_dashboard/api/rest/utils.py", line 128, in _wrapped
[Thu Jun 06 23:24:09.770322 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] data = function(self, request, *args, **kw)
[Thu Jun 06 23:24:09.770328 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] File "/usr/lib/python3/dist-packages/openstack_dashboard/api/rest/network.py", line 70, in post
[Thu Jun 06 23:24:09.770335 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] None, params)
[Thu Jun 06 23:24:09.770343 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730] TypeError: tenant_floating_ip_allocate() takes from 1 to 3 positional arguments but 4 were given
[Thu Jun 06 23:24:09.770356 2019] [wsgi:error] [pid 26848:tid 140634143590144] [remote 172.26.25.159:58730]


[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/663805

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663805
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=92d832028df65cb95030b2a585764a62dc1c0b75
Submitter: Zuul
Branch: master

commit 92d832028df65cb95030b2a585764a62dc1c0b75
Author: Sam Morrison <email address hidden>
Date: Fri Jun 7 10:10:09 2019 +1000

    Fix tenant floating_ip_allocation call in neutron rest api.

    The call to allocate a new floating IP was incorrecting calling
    tenant_floating_ip_allocate, this is used by neutron-lbaas-dashboard.

    Change-Id: Ia4d1367ccd309a074a0ea84a555d7de6c07971a6
    Closes-bug: #1831954

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 16.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/696702

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/696703

[Stefan Nica (stefan.nica)]

This is still reproducible with Rocky and the Octavia UI dashboard.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696702
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=489af71a6b976e5aabf7fcc8b1919f812dadf1c7
Submitter: Zuul
Branch: stable/stein

commit 489af71a6b976e5aabf7fcc8b1919f812dadf1c7
Author: Sam Morrison <email address hidden>
Date: Fri Jun 7 10:10:09 2019 +1000

    Fix tenant floating_ip_allocation call in neutron rest api.

    The call to allocate a new floating IP was incorrecting calling
    tenant_floating_ip_allocate, this is used by neutron-lbaas-dashboard.

    Change-Id: Ia4d1367ccd309a074a0ea84a555d7de6c07971a6
    Closes-bug: #1831954
    (cherry picked from commit 92d832028df65cb95030b2a585764a62dc1c0b75)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696703
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5a2c827ddec9462e2128212ac927d678d26f0d9a
Submitter: Zuul
Branch: stable/rocky

commit 5a2c827ddec9462e2128212ac927d678d26f0d9a
Author: Sam Morrison <email address hidden>
Date: Fri Jun 7 10:10:09 2019 +1000

    Fix tenant floating_ip_allocation call in neutron rest api.

    The call to allocate a new floating IP was incorrecting calling
    tenant_floating_ip_allocate, this is used by neutron-lbaas-dashboard.

    Change-Id: Ia4d1367ccd309a074a0ea84a555d7de6c07971a6
    Closes-bug: #1831954
    (cherry picked from commit 92d832028df65cb95030b2a585764a62dc1c0b75)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 14.1.0 release.