stein requires python-cinderclient >= 4.0.0

[Corey Bryant]

Attempting to create volume from stein dashboard fails with "Error: Unable to create volume.".

The log shows:
[Tue Apr 09 17:40:58.263170 2019] [wsgi:error] [pid 18815:tid 140441351403264] [remote 10.5.0.17:50962] Recoverable error: Invalid input for field/attribute volume. Value: {'size': 1,
'consistencygroup_id': None, 'snapshot_id': None, 'name': 'b1', 'description': '', 'volume_type': '', 'user_id': None, 'project_id': None, 'availability_zone': 'nova', 'status': 'creating', 'attach_status': 'detached', 'metadata': {}, 'imageRef': None, 'source_volid': None, 'source_replica': None, 'multiattach': False, 'backup_id': None}. Additional properties are not allowed ('project_id', 'user_id', 'status', 'attach_status', 'source_replica' were unexpected) (HTTP 400) (Request-ID: req-e64a3589-403c-4c58-87dd-58233a70bde6)

We're running with python3-cinderclient 1:3.5.0-0ubuntu1. Upgrading to python3-cinderclient 1:4.1.0-0ubuntu1 fixes this.

Relevent python-cinderclient commit from version 4.0.0:

commit 8d566689001a442c2312e366acc167af88888fd3
Author: Neha Alhat <email address hidden>
Date: Thu Jun 7 18:22:16 2018 +0530

    Remove unnecessary parameters from volume create APIs

    As per Cinder code, following parameters are not required to be
    passed in the request body of create volume API.

        * status
        * user_id
        * attach_status
        * project_id
        * source_replica

    If you pass these parameters, previously it was ignored but in the
    schema validation changes[1] we don't allow additionalProperties to be
    passed in the request body. If user passes additional parameters which
    are not as per API specs[2], then it will be rejected with 400 error.
    On patch[3], tempest tests: test_volume_snapshot_create_get_list_delete,
    test_volume_create_get_delete" are failing because of these unnecessary
    parameters.

    This patch removes these unnecessary parameters passed to the create
    Volume API.

    [1]https://blueprints.launchpad.net/cinder/+spec/json-schema-validation
    [2]https://review.openstack.org/#/c/507386/
    [3]https://review.openstack.org/#/c/573093/

    Change-Id: I37744bfd0b0bc59682c3e680c1200f608ad3991b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/651382

[Launchpad Janitor (janitor)]

This bug was fixed in the package horizon - 3:15.0.0~rc2-0ubuntu2

---------------
horizon (3:15.0.0~rc2-0ubuntu2) disco; urgency=medium

  * d/p/set-min-version-of-python-cinderclient-to-4.0.0.patch: Ensure
    python3-cinderclient is >= 4.0.0, as this is required for create/update
    of volumes from the horizon dashboard (LP: #1824017).

 -- Corey Bryant <email address hidden> Tue, 09 Apr 2019 17:12:30 -0400

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651382
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f9b520f377816341d2e79106bfddf94c5afab390
Submitter: Zuul
Branch: master

commit f9b520f377816341d2e79106bfddf94c5afab390
Author: Corey Bryant <email address hidden>
Date: Tue Apr 9 17:01:10 2019 -0400

    Set min version of python-cinderclient to 4.0.0

    As of Stein, a minimum of python-cinderclient 4.0.0 is required to
    create a volume. Cinder schema no longer accepts additional
    properties on volume create that are not part of the API spec [1].

    [1] https://review.openstack.org/#/c/573093/

    Change-Id: I0fc4d5db39080985b471fe2465b7078e37417e4d
    Closes-Bug: #1824017

[James Page (james-page)]

This bug was fixed in the package horizon - 3:15.0.0~rc2-0ubuntu2~cloud0
---------------

 horizon (3:15.0.0~rc2-0ubuntu2~cloud0) bionic-stein; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:15.0.0~rc2-0ubuntu2) disco; urgency=medium
 .
   * d/p/set-min-version-of-python-cinderclient-to-4.0.0.patch: Ensure
     python3-cinderclient is >= 4.0.0, as this is required for create/update
     of volumes from the horizon dashboard (LP: #1824017).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651486
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b086505d31233b098f50578e3a92dcd35c600315
Submitter: Zuul
Branch: stable/stein

commit b086505d31233b098f50578e3a92dcd35c600315
Author: Corey Bryant <email address hidden>
Date: Tue Apr 9 17:01:10 2019 -0400

    Set min version of python-cinderclient to 4.0.0

    As of Stein, a minimum of python-cinderclient 4.0.0 is required to
    create a volume. Cinder schema no longer accepts additional
    properties on volume create that are not part of the API spec [1].

    [1] https://review.openstack.org/#/c/573093/

    Change-Id: I0fc4d5db39080985b471fe2465b7078e37417e4d
    Closes-Bug: #1824017

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/658514

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/658514
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3c600cbbf5b0ca09f9c0d66e7a212dd46b36a4a
Submitter: Zuul
Branch: master

commit e3c600cbbf5b0ca09f9c0d66e7a212dd46b36a4a
Author: Akihiro Motoki <email address hidden>
Date: Sat May 11 10:38:40 2019 +0900

    Add relnote on cinderclient minver bump to 4.0.1

    A fix for bug 1824017 bumped the minimum version requirement of
    python-cinderclient to 4.0.0. The fix was backported to stable/stein,
    so the minimum version bump should be covered by a release note.

    python-cinderclient requirement is bumped to >=4.0.1
    as 4.0.0 is blocked by global-requirements.txt [1].

    It was suggested by the release team in the review of
    horizon stein update release [2].

    [1] https://opendev.org/openstack/requirements/src/commit/1baf07a77333fc57d9d4a669d0265b0e687fd031/global-requirements.txt#L256
    [2] https://review.opendev.org/#/c/655447/

    Change-Id: I2b43e159da7e58980b2810a104ae2418f237d1c7
    Related-Bug: #1824017

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/659718

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659718
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0d70b2e68ab7544c5d2157e5992572d907442fac
Submitter: Zuul
Branch: stable/stein

commit 0d70b2e68ab7544c5d2157e5992572d907442fac
Author: Akihiro Motoki <email address hidden>
Date: Sat May 11 10:38:40 2019 +0900

    Add relnote on cinderclient minver bump to 4.0.1

    A fix for bug 1824017 bumped the minimum version requirement of
    python-cinderclient to 4.0.0. The fix was backported to stable/stein,
    so the minimum version bump should be covered by a release note.

    python-cinderclient requirement is bumped to >=4.0.1
    as 4.0.0 is blocked by global-requirements.txt [1].

    It was suggested by the release team in the review of
    horizon stein update release [2].

    [1] https://opendev.org/openstack/requirements/src/commit/1baf07a77333fc57d9d4a669d0265b0e687fd031/global-requirements.txt#L256
    [2] https://review.opendev.org/#/c/655447/

    Change-Id: I2b43e159da7e58980b2810a104ae2418f237d1c7
    Related-Bug: #1824017
    (cherry picked from commit e3c600cbbf5b0ca09f9c0d66e7a212dd46b36a4a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 16.0.0.0b1 development milestone.