Network topology graph incorrectly renders instances in non-default availability zone

[Graham Lenton]

Instances not in the default availability zone (which is 'nova' by default) are displayed incorrectly in the Network topology graph in Horizon - as shown in the attached image.

If you drag the errant instance you can see it is actually rendered outside the scope of the 'colour bubble', whereas instances in the default availability zone are always kept within the 'colour bubble' however much you attempt to drag them out.

Looking at https://github.com/openstack/horizon/blame/master/openstack_dashboard/static/js/horizon.networktopology.js it seems that checks are made against port.device_owner to see if it matches the value 'compute:nova', but for instances in other availability zones, the value is not 'compute:nova' but 'compute:name-of-other-az'.

I think it would be sufficient to change the checks to be port.device_owner.startsWith("compute:") but I have not yet been able to test this.

This bug is present in all versions of Horizon since the 'curvature topology' was introduced in Liberty in 2015.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/645066

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645066
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ffbe0e2f2f96556f4476ea3873af1bc628c879ca
Submitter: Zuul
Branch: master

commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 21 16:41:37 2019 +0900

    network topology: handle port AZ correctly

    Previously d3 version of the network topology view handles ports with
    device_owner 'compute:nova' and 'compute:None' specially. This leads
    to the situtaion that neutron ports with non-default AZ are not shown
    properly. There is no reason to handle neutron ports with the default
    AZ differently. What we would like to do is just to classify neutron
    ports attached to nova servers.

    This commit changes the logic to check device_owner of ports have
    a prefix 'compute:'. Note that we also need to check if device_owner
    is a string before checking the prefix.

    Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
    Closes-Bug: #1820260

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/645317

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/645474

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/645475

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645475
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=94bf61662c43e484d878267962019c076a6a8b7b
Submitter: Zuul
Branch: stable/queens

commit 94bf61662c43e484d878267962019c076a6a8b7b
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 21 16:41:37 2019 +0900

    network topology: handle port AZ correctly

    Previously d3 version of the network topology view handles ports with
    device_owner 'compute:nova' and 'compute:None' specially. This leads
    to the situtaion that neutron ports with non-default AZ are not shown
    properly. There is no reason to handle neutron ports with the default
    AZ differently. What we would like to do is just to classify neutron
    ports attached to nova servers.

    This commit changes the logic to check device_owner of ports have
    a prefix 'compute:'. Note that we also need to check if device_owner
    is a string before checking the prefix.

    Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
    Closes-Bug: #1820260
    (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645474
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6b30d42c3347398562c9a9e789a87978d4988385
Submitter: Zuul
Branch: stable/rocky

commit 6b30d42c3347398562c9a9e789a87978d4988385
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 21 16:41:37 2019 +0900

    network topology: handle port AZ correctly

    Previously d3 version of the network topology view handles ports with
    device_owner 'compute:nova' and 'compute:None' specially. This leads
    to the situtaion that neutron ports with non-default AZ are not shown
    properly. There is no reason to handle neutron ports with the default
    AZ differently. What we would like to do is just to classify neutron
    ports attached to nova servers.

    This commit changes the logic to check device_owner of ports have
    a prefix 'compute:'. Note that we also need to check if device_owner
    is a string before checking the prefix.

    Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
    Closes-Bug: #1820260
    (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645317
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=273de58cccfd7c82dbe7372b7c8a7d9d9dd39b06
Submitter: Zuul
Branch: stable/stein

commit 273de58cccfd7c82dbe7372b7c8a7d9d9dd39b06
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 21 16:41:37 2019 +0900

    network topology: handle port AZ correctly

    Previously d3 version of the network topology view handles ports with
    device_owner 'compute:nova' and 'compute:None' specially. This leads
    to the situtaion that neutron ports with non-default AZ are not shown
    properly. There is no reason to handle neutron ports with the default
    AZ differently. What we would like to do is just to classify neutron
    ports attached to nova servers.

    This commit changes the logic to check device_owner of ports have
    a prefix 'compute:'. Note that we also need to check if device_owner
    is a string before checking the prefix.

    Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
    Closes-Bug: #1820260
    (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/648205

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/648205
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a729170c9ff6c56dd2f73a3b899299bbc44ea80e
Submitter: Zuul
Branch: stable/pike

commit a729170c9ff6c56dd2f73a3b899299bbc44ea80e
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 21 16:41:37 2019 +0900

    network topology: handle port AZ correctly

    Previously d3 version of the network topology view handles ports with
    device_owner 'compute:nova' and 'compute:None' specially. This leads
    to the situtaion that neutron ports with non-default AZ are not shown
    properly. There is no reason to handle neutron ports with the default
    AZ differently. What we would like to do is just to classify neutron
    ports attached to nova servers.

    This commit changes the logic to check device_owner of ports have
    a prefix 'compute:'. Note that we also need to check if device_owner
    is a string before checking the prefix.

    Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
    Closes-Bug: #1820260
    (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 14.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 16.0.0.0b1 development milestone.