Attribute Error just after creating a volume group

Bug #1817054 reported by Akihiro Motoki
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

Just after creating a volume group, Attribute error happens.
http://paste.openstack.org/show/745454/

Revision history for this message
Akihiro Motoki (amotoki) wrote :

It was reported by two folks in comments for https://review.openstack.org/#/c/638071/.

Although I cannot reproduce this in my local environment, it should happen.
From my static investigation, I guess it happens when a volume group is in "creating" status.
UpdateRow get_data() does not populate has_snapshots attribute so I guess this is the cause.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/volume_groups/tables.py#L109

Changed in horizon:
importance: Undecided → Medium
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I am not sure my guess in #1 is correct or not.
I still cannot find a good way to reproduce this with the master branch...
I would like to see more input from folks who really experience this.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/638709

Changed in horizon:
assignee: nobody → Vadym Markov (vmarkov)
status: New → In Progress
Changed in horizon:
assignee: Vadym Markov (vmarkov) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/638709
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5e53e014d96e4a221be4479a1584c2b329fa7c9d
Submitter: Zuul
Branch: master

commit 5e53e014d96e4a221be4479a1584c2b329fa7c9d
Author: BubaVV <email address hidden>
Date: Fri Feb 22 17:04:13 2019 +0200

    Fix recoverable error at volume group create

    Cinder API response for group in 'creating' state handled incorrectly
    and has_snapshots attribute is not populated. This attribute is checked
    during various operations with groups and error is generated if it is
    absent. However, this error has no consequences except message in log.

    When a created group is in 'creating' state, UpdateRow class is
    responsible for retrieving a group data.
    Previously UpdateRow.get_data did not populate 'has_snapshots' attribute.
    This commit adds a similar logic as IndexView does.

    Admin volume groups table has a same problem. UpdateRow class
    now inherits UpdateRow from the project table.

    Co-Authored-By: Akihiro Motoki <email address hidden>
    Change-Id: Ie06de2a09ddd38bd5c43bfa9b9240f327ca0e1b7
    Closes-bug: #1817054

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0rc1

This issue was fixed in the openstack/horizon 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.