Remove unnecessary disclaimer from the login page

Bug #1774623 reported by Vadym Markov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Vadym Markov

Bug Description

Horizon has WEBSSO_CHOICES config option which allows user to select auth mechanism to login, like Keystone credentials or OpenID. List of valid auth choices also is configurable. If this option is enabled, user gets list of auth variants and disclaimer "If you are not sure which authentication method to use, contact your administrator". Disclaimer is shown even if list has only one possible option, which is confusing.

Way to reproduce:
Enable WEBSSO_ENABLED and WEBSSO_CHOICES options in Horizon config and make WEBSSO_CHOICES include exactly one element

Revision history for this message
Vadym Markov (vmarkov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571702

Changed in horizon:
assignee: nobody → Vadym Markov (vmarkov)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/571702
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=61a79a9b7a2c6421381a36ec4c3c2dc27681626a
Submitter: Zuul
Branch: master

commit 61a79a9b7a2c6421381a36ec4c3c2dc27681626a
Author: vmarkov <email address hidden>
Date: Fri Jun 1 13:56:56 2018 +0300

    Show WEBSSO disclaimer only when it is needed

    Horizon can support several auth mechanisms, i.e. Keystone creds and
    OpenID. User allowed to choose proper way of auth and disclaimer is
    shown. But it is possible to allow choose from the only variant, and in
    this case disclaimer also shown, which is confusing. Proposed patch fix
    disclaimer display and makes it reasonable

    Closes-bug: #1774623
    Change-Id: Ib039c6fdf1e4cd21b5ebe426fe2a15355a37353c

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b2

This issue was fixed in the openstack/horizon 14.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.