openstack_dashboard.api.nova.QuotaSet does not exclude nova-network quotas

Bug #1743589 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

ignore_quotas of openstack_dashboard.api.nova.QuotaSet [1] was introduced to exclude nova-network quotas, but it turns out it does not work.

[2] is a session example. It is expected that api_nova.QuotaSet(quotas) does not include nova-network related quotas but actually nova-network related quotas are included.

[1] https://github.com/openstack/horizon/blob/e129ba919260e85881a08ab33f0b142c6603c988/openstack_dashboard/api/nova.py#L242-L247
[2] http://paste.openstack.org/show/645735/

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Note that this does not affect horizon behavior directly, but it is confusing from the perspective of code maintenance.

Changed in horizon:
importance: Undecided → Medium
assignee: nobody → Akihiro Motoki (amotoki)
Changed in horizon:
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/534386
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=986e90248b462b1e8c8e2033caee68ebd50e0bf8
Submitter: Zuul
Branch: master

commit 986e90248b462b1e8c8e2033caee68ebd50e0bf8
Author: Akihiro Motoki <email address hidden>
Date: Mon Jan 15 06:09:09 2018 +0900

    Exclude nova-network quotas properly

    openstack_dashboard.api.nova.QuotaSet was introduced to exclude
    nova-network properly, but it did not work because QuotaSet does
    not support 'in' and 'del' operations.
    This commit fixes the logic and add a unit test.

    Closes-Bug: #1743589
    Change-Id: I8c3bfe985cccdf53fd555bf185c293806c14b6f6

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b1

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.