Instance resize crash when cookie "horizon_language" is set

Bug #1732941 reported by Mateo Boudet
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Expired
Undecided
Unassigned

Bug Description

Hello,

I have this bug in the newton release, but it might have persisted in further releases.

When the cookie "horizon_language" is set (after the user changed his options for instance), the instance resize workflow hang at the selection of the new flavor with a JSON.parse error.

Looking at the code, horizon tries to access the value of the cookie with
*var lang = horizon.cookies.get('horizon_language');*

However, since the cookie value is a simple string (ex : "en"), the function hangs when trying to convert it to JSON.

The function getRaw() should be called instead.

The file shoud be "horizon.quota.js" in both newton and following releases.

Apologies if it was already fixed.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I cannot reproduce this in horizon queens. I changed the language to Japanese and resized my instance from m1.tiny to m1.small. The code has not been changed for a while and we confirmed resize works in Newton during translation check.
Let me mark it as Incomplete.

Changed in horizon:
status: New → Incomplete
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Do you mean JavaScript code raises a trace rather than saying that the resize feature is broken?

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Looking at the history of horizon.quota.js, the code was changed in commit 89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe "Add i18n support to Quota.humanizeNumbers".
I think the issue has gone in ocata or later releases.

Revision history for this message
Mateo Boudet (darkmouton) wrote :

Yes, the issue was the Javascript trace. The resize feature did work as expected with no language cookie set.

We have updated to Ocata and cannot reproduce the bug anymore, so the issue does seems to be fixed post Newton.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for OpenStack Dashboard (Horizon) because there has been no activity for 60 days.]

Changed in horizon:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.