Image metadata button doesn't work if only one item is available

Bug #1731884 reported by Ivan Kolodyazhny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ivan Kolodyazhny

Bug Description

If we have only one metadata item assigned, toggle button look confusing.

Steps to reproduce:
1. Open Project -> Compute -> Images panel
2. Click on 'Update Metadata' from image actions menu
3. Add one any metadata item to image and click 'Save' button
4. Expand image details clicking on '>' button

Actual: There is button ('CIM Processor Allocation Setting' in my case') which does nothing just confuses user

Expected result: if only one metadata item is assigned to an image, the button should not be clickable

Changed in horizon:
assignee: nobody → Ivan Kolodyazhny (e0ne)
status: New → In Progress
Revision history for this message
Ying Zuo (yingzuo) wrote :

I assumed this is reproducible with the master branch since the horizon version is not specified. The images panel should be under the compute panel group, not system. And I don't see the "Image Signature Verification" button. Does it need some specific configuration for the image?

Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :

Sorry, Ying, bug description is not accurate. "Image Signature Verification" becomes visible once you sign it with Barbican. This is also reproducible with any other metadata field (if only one is assigned to image)

Revision history for this message
Ying Zuo (yingzuo) wrote :

I am still confused about what the issue is. The patch for this seems to be something else: https://review.openstack.org/#/c/518965. Can you provide the steps to reproduce and current/expected behavior?

Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :
description: updated
Revision history for this message
Ivan Kolodyazhny (e0ne) wrote :

I've updated bug description with steps to reproduce and current/expected behaviors. You can also see current behavior in the attached screenshot.

Revision history for this message
Ying Zuo (yingzuo) wrote :

Thanks Ivan.

Ying Zuo (yingzuo)
Changed in horizon:
importance: Undecided → Low
milestone: none → queens-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/518965
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=59b18f30562156b468fccd81f15f8ec0311b8dc8
Submitter: Zuul
Branch: master

commit 59b18f30562156b468fccd81f15f8ec0311b8dc8
Author: Anton Arefiev <email address hidden>
Date: Fri Nov 10 18:04:23 2017 +0100

    Disable metadata switch if only one item is available

    Single metadata item on image details looks like action button,
    which is confusing, so change cursor from pointer to default.

    Closes-Bug: #1731884
    Change-Id: I50b9a9c3878866249561a58c92aeafff4dffc949
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b2

This issue was fixed in the openstack/horizon 13.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.