no need to discover panel in _autodiscover in Site class

Bug #1717149 reported by chaoliu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Confirmed
Low
chaoliu

Bug Description

no need to discover panel in Site class since the job is done by _audodiscover() method in Dashboard class

chaoliu (liuchao)
Changed in horizon:
assignee: nobody → chaoliu (liuchao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/503911

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/503911
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb39de18e41a5e50f7f840336429109e847c816d
Submitter: Jenkins
Branch: master

commit fb39de18e41a5e50f7f840336429109e847c816d
Author: chao liu <email address hidden>
Date: Wed Sep 13 20:14:54 2017 -0700

    No need to discover panel in Site class

    Panel discovery is done by the _audodiscover() method in
    the Dashboard class later

    Change-Id: I0261a3cd9ad411185ab68ef4ae3b35a8d7ae3b23
    Closes-Bug: #1717149

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Luigi Toscano (ltoscano) wrote :

This broke the unit tests of the sahara dashboard. Compare:

https://review.openstack.org/#/c/504760/

with

https://review.openstack.org/#/c/505575/

Akihiro Motoki (amotoki)
Changed in horizon:
status: Fix Released → Confirmed
Revision history for this message
Akihiro Motoki (amotoki) wrote :

This breaks sahara-dashboard gate and is reverted in https://review.openstack.org/506108

Let's revert the revert patch again after finding out what is not good for sahara-dashboard and fix similar issues in other horizon plugins (if any).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.